Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uncomment TIME_ZONE in env_sample.hjson #1500

Closed
lsloan opened this issue Apr 3, 2023 · 0 comments · Fixed by #1516
Closed

uncomment TIME_ZONE in env_sample.hjson #1500

lsloan opened this issue Apr 3, 2023 · 0 comments · Fixed by #1516
Assignees
Labels
📖 documentation Involves updates to the README, CONTRIBUTING, or other supporting text files

Comments

@lsloan
Copy link
Member

lsloan commented Apr 3, 2023

Problem

I was helping Chris Lalande of Wisconsin understand the differences between various timestamps in her school's deployment of MyLA. It turns out that although her school is in the Central time zone, MyLA's admin interface is showing times in the Eastern time zone (EDT, specifically). She's not confirmed it yet, but I think because the TIME_ZONE line in env_sample.hjson is commented out, they didn't set their local time zone in Wisconsin's deployment.

Solution

To avoid admins forgetting to set their time zone, TIME_ZONE should not be commented out in sample config file.

@jennlove-um jennlove-um added this to To do in MyLA-2023.02.01 via automation May 24, 2023
@jennlove-um jennlove-um added the 📖 documentation Involves updates to the README, CONTRIBUTING, or other supporting text files label May 24, 2023
@lsloan lsloan moved this from To do to In progress in MyLA-2023.02.01 Jun 22, 2023
lsloan added a commit to lsloan/myla that referenced this issue Jun 22, 2023
To avoid problems with admins forgetting to set their time zone.  They may comment it out themselves if they want MyLA to use the value of the `TZ` environment variable.
@jennlove-um jennlove-um moved this from In progress to Review/QA in MyLA-2023.02.01 Aug 17, 2023
@jonespm jonespm moved this from Review/QA to Review/QA - DEV in MyLA-2023.02.01 Sep 14, 2023
@jonespm jonespm moved this from Review/QA - DEV to Done in MyLA-2023.02.01 Sep 14, 2023
MyLA-2023.02.01 automation moved this from Done to Review/QA Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Involves updates to the README, CONTRIBUTING, or other supporting text files
Projects
No open projects
MyLA-2023.02.01
  
Review/QA
Development

Successfully merging a pull request may close this issue.

2 participants