Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm build is not considering package-lock.json, some packages are upgraded #1527

Closed
jonespm opened this issue Aug 24, 2023 · 1 comment · Fixed by #1528
Closed

npm build is not considering package-lock.json, some packages are upgraded #1527

jonespm opened this issue Aug 24, 2023 · 1 comment · Fixed by #1528
Assignees

Comments

@jonespm
Copy link
Member

jonespm commented Aug 24, 2023

Thank you for contributing to this project!

Expected behavior (A description of what you expected to happen) :

Packages are static between deployments and updated manually. However it looks like they're updated to newer versions.

Additional context (Add any other context about the problem here) :

It was noticed that package-lock.json is ignored and not included in the builds. This file is needed to ensure the versions are predictable/static.

@jonespm jonespm self-assigned this Aug 24, 2023
jonespm added a commit to jonespm/student-dashboard-django that referenced this issue Aug 24, 2023
@jonespm jonespm added this to To do in MyLA-2023.02.01 via automation Aug 24, 2023
@jonespm jonespm moved this from To do to In progress in MyLA-2023.02.01 Aug 24, 2023
@jonespm jonespm linked a pull request Aug 24, 2023 that will close this issue
MyLA-2023.02.01 automation moved this from In progress to Review/QA Aug 24, 2023
@jennlove-um jennlove-um moved this from Review/QA to Review/QA - DEV in MyLA-2023.02.01 Sep 14, 2023
@pushyamig
Copy link
Contributor

Tested a couple packages in Package-lock.json downloaded/used in Myla Beta

  1. Apollo:
:/code/node_modules/@apollo/client$ cat version.js
export var version = '3.5.10';

2. D3 version:

:/code/node_modules/d3$ cat package.json
{
  "name": "d3",
  "version": "7.6.1",

Test passes

@pushyamig pushyamig moved this from Review/QA - DEV to Done in MyLA-2023.02.01 Sep 14, 2023
MyLA-2023.02.01 automation moved this from Done to Review/QA Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
MyLA-2023.02.01
  
Review/QA
Development

Successfully merging a pull request may close this issue.

2 participants