Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1088 - Check if flatpages.first is set #1287

Merged
merged 1 commit into from Jul 8, 2021
Merged

Fixes #1088 - Check if flatpages.first is set #1287

merged 1 commit into from Jul 8, 2021

Conversation

jonespm
Copy link
Member

@jonespm jonespm commented Jul 8, 2021

No description provided.

@jonespm jonespm requested review from zqian and ssciolla July 8, 2021 16:03
@jonespm jonespm linked an issue Jul 8, 2021 that may be closed by this pull request
Change the way classes are imported from Material-UI #1284
Open
@ssciolla ssciolla added Frontend 🪳 bug Something isn't working labels Jul 8, 2021
@ssciolla ssciolla added this to In progress in MyLA-2021.03.01 Jul 8, 2021
@ssciolla ssciolla linked an issue Jul 8, 2021 that may be closed by this pull request
Exception/tracebacks when loading frontend/index.html template #1088
Closed
@ssciolla ssciolla removed a link to an issue Jul 8, 2021
Change the way classes are imported from Material-UI #1284
Open
ssciolla
ssciolla approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@ssciolla ssciolla left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work. Tested locally.

@jonespm jonespm merged commit 7eff037 into tl-its-umich-edu:master Jul 8, 2021
MyLA-2021.03.01 automation moved this from In progress to Review/QA Jul 8, 2021
@jonespm jonespm deleted the issue_1088 branch July 8, 2021 17:36
@zqian zqian removed this from Review/QA in MyLA-2021.03.01 Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssciolla ssciolla ssciolla approved these changes

@zqian zqian Awaiting requested review from zqian

Assignees
No one assigned
Labels
🪳 bug Something isn't working Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception/tracebacks when loading frontend/index.html template
2 participants
@jonespm @ssciolla