Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Django to 3.2 and other Python dependencies (#1286) #1300

Merged
merged 17 commits into from Sep 13, 2021

Conversation

ssciolla
Copy link
Contributor

@ssciolla ssciolla commented Aug 9, 2021

The PR aims to resolve #1084 and #1286.

I've built with these changes, and everything seems to work so far. I will be looking more closely at each updated dependency to see where it is used, what has changed, and whether I need to do anything special to test it. Any assistance with testing would be appreciated.

To do

  • Scan dependencies and update if possible
    • Find libraries with new releases using PyPi, and update requirements.txt
    • Update webpack-bundle-tracker npm package to ensure compatibility with django-webpack-loader
    • Execute npm install in repository to update package-lock.json
    • Remove outdated and/or minimally used dependencies, including django-settings-export, django-model-utils, and django-macros.
    • Fix bugs associated with updates to Django, pinax-eventlog, and pandas.
  • Fix Django warnings
    • Specify DEFAULT_AUTO_FIELD
    • Replace NullBooleanField usage

Testing

  • Run with and without LTI
  • Review logs associated with each view and try functionality
  • Run cron with a few different courses
  • Run management commands

…r for compatibility; update package-lock.json
@ssciolla ssciolla added ⚙️ backend dependencies Pull requests that update a dependency file 📈 enhancement New feature or request labels Aug 9, 2021
@ssciolla ssciolla changed the title Update Django and related dependencies (#1286) Update Django to 3.2 and other Python dependencies (#1286) Aug 11, 2021
@ssciolla ssciolla linked an issue Sep 3, 2021 that may be closed by this pull request
@ssciolla ssciolla marked this pull request as ready for review September 3, 2021 19:35
@ssciolla
Copy link
Contributor Author

ssciolla commented Sep 3, 2021

I think this is ready for review and further testing. Please let me know if you have any other questions. Issue #1286 has a lot of notes and linked resources about the dependency changes.

Copy link
Member

@jonespm jonespm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments, I think this is good to get in and we can create new issues if needed for the createkeys and the roles change (if there isn't one for that yet)

dashboard/templates/base.html Show resolved Hide resolved
dashboard/templates/base.html Outdated Show resolved Hide resolved
@ssciolla
Copy link
Contributor Author

ssciolla commented Sep 9, 2021

@zqian and @pushyamig, do either of you plan to or want to review this before it's merged?

@pushyamig
Copy link
Contributor

@ssciolla please go ahead and merge it if you like

@ssciolla ssciolla merged commit 11987be into tl-its-umich-edu:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ backend dependencies Pull requests that update a dependency file 📈 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade backend dependencies, including Django to 3.2 Remove the package django-settings-export
3 participants