Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1072 - Code cleanup for unused registration module #1369

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Fixes #1072 - Code cleanup for unused registration module #1369

merged 1 commit into from
Jun 16, 2022

Conversation

jonespm
Copy link
Member

@jonespm jonespm commented Apr 13, 2022

No description provided.

@jonespm jonespm linked an issue Apr 13, 2022 that may be closed by this pull request
Remove django-registration and registration #1072
Closed
@zqian zqian requested review from zqian and ssciolla June 16, 2022 19:13
zqian
zqian approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@zqian zqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes with random clicks inside MyLA tool. No errors in log file; I an still do admin login with /accounts/login/

@jonespm jonespm merged commit b94ed3a into tl-its-umich-edu:master Jun 16, 2022
@jonespm jonespm deleted the issue_1072 branch June 16, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zqian zqian zqian approved these changes

@ssciolla ssciolla Awaiting requested review from ssciolla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove django-registration and registration
2 participants
@jonespm @zqian