Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-1332 added cron query to retrieve Canvas page usage events #1391

Merged
merged 3 commits into from
Aug 20, 2022
Merged

issue-1332 added cron query to retrieve Canvas page usage events #1391

merged 3 commits into from
Aug 20, 2022

Conversation

zqian
Copy link
Member

@zqian zqian commented Jul 8, 2022 •
edited by pushyamig

Fixes #1332

@zqian zqian requested a review from jonespm July 8, 2022 22:44
@zqian zqian added 📅 cron config change needed Changes are needed/included that may affect configuration files labels Jul 8, 2022
@zqian zqian linked an issue Jul 8, 2022 that may be closed by this pull request
Potential for duplicate resource identifiers (Pages visualization) #1332
Closed
@jonespm jonespm changed the title issue-1332 added cron query to retrieve Canvavs page usage events issue-1332 added cron query to retrieve Canvas page usage events Jul 13, 2022
@zqian zqian requested review from ssciolla and lsloan July 20, 2022 15:43
@pushyamig
Copy link
Contributor

I will review this today.

pushyamig
pushyamig reviewed Aug 17, 2022
View reviewed changes
config/env_sample.hjson Outdated Show resolved Hide resolved
pushyamig
pushyamig reviewed Aug 17, 2022
View reviewed changes
config/env_sample.hjson Outdated Show resolved Hide resolved
@zqian
update the resource_id field for pages access event
67d9159 
using the format of '@course_id/pages/@page_id', based on the review
pushyamig
pushyamig reviewed Aug 19, 2022
View reviewed changes
config/env_sample.hjson Outdated Show resolved Hide resolved
@pushyamig
Copy link
Contributor

I am going to test the new changes in the afternoon.

@pushyamig
Copy link
Contributor

I finished my review, and the changes adding pages seem to working. I will let other review and approve it

jonespm
jonespm reviewed Aug 19, 2022
View reviewed changes
config/env_sample.hjson Outdated Show resolved Hide resolved
jonespm
jonespm reviewed Aug 19, 2022
View reviewed changes
config/env_sample.hjson Outdated Show resolved Hide resolved
jonespm
jonespm approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@jonespm jonespm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The query looks good. I left a few comments that could improve the consistency or add some commentary as to why these were needed.

@zqian zqian merged commit 16587a6 into tl-its-umich-edu:master Aug 20, 2022
@jonespm jonespm added this to Review/QA - DEV in MyLA-2022.01.03 Sep 20, 2022
jonespm pushed a commit to jonespm/student-dashboard-django that referenced this pull request Sep 20, 2022
@zqian @jonespm
issue-1332 added cron query to retrieve Canvas page usage events (tl-…
dca3a82 
…its-umich-edu#1391)
@jonespm jonespm removed this from Review/QA - DEV in MyLA-2022.01.03 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlongland jlongland jlongland left review comments

@pushyamig pushyamig pushyamig left review comments

@jonespm jonespm jonespm approved these changes

Assignees
No one assigned
Labels
config change needed Changes are needed/included that may affect configuration files 📅 cron
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potential for duplicate resource identifiers (Pages visualization)
4 participants
@zqian @pushyamig @jonespm @jlongland