Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #1435 cron queries update #1436

Merged
merged 2 commits into from
Sep 16, 2022
Merged

issue #1435 cron queries update #1436

merged 2 commits into from
Sep 16, 2022

Conversation

zqian
Copy link
Member

@zqian zqian commented Sep 15, 2022 •
edited

This PR includes the following query updates:

  1. UDW course query returns null value for course id
  2. UDP submission query returns unreleased grade for auto graded-submissions

@zqian zqian requested a review from jonespm September 15, 2022 19:25
@zqian zqian changed the title issue_1435 address the null course id issue for UDW cron job issue #1435 address the null course id issue for UDW cron job Sep 15, 2022
@zqian zqian linked an issue Sep 15, 2022 that may be closed by this pull request
empty course_id returned by UDW course query; and unreleased grade returned by UDP submission query #1435
Closed
jonespm
jonespm approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@jonespm jonespm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran this locally, it's both fixing the case of nulls, the case of the wrong id and a case with an edge case in grading.

@jonespm
Copy link
Member

jonespm commented Sep 15, 2022

@zqian Can you update the description of this and the issue to reflect that this also fixes a grading issue in the UDP for unreleased submissions?

@zqian zqian changed the title issue #1435 address the null course id issue for UDW cron job issue #1435 cron queries update Sep 16, 2022
@zqian
Copy link
Member Author

zqian commented Sep 16, 2022

I've updated the description. Going to merge it in.

@zqian zqian merged commit c5c8ccc into tl-its-umich-edu:master Sep 16, 2022
@zqian zqian deleted the issue_1435 branch September 16, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonespm jonespm jonespm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

empty course_id returned by UDW course query; and unreleased grade returned by UDP submission query
2 participants
@zqian @jonespm