Fixes #1466 - Limit display to a configurable number of resources #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display this limit to the user
jonespm
changed the title
ssciolla
reviewed
Mar 9, 2023
ssciolla
reviewed
Mar 9, 2023
Co-authored-by: Sam Sciolla <35741256+ssciolla@users.noreply.github.com>
ssciolla
reviewed
Mar 9, 2023
Check if value is set Change divs to Typography Fix a few other standard formatting issues
Co-authored-by: Sam Sciolla <35741256+ssciolla@users.noreply.github.com>
ssciolla
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display this limit to the user
I've tested this locally, I need to test if the header works with CORS on the server.
I could have also added this metadata to the JSON but that seems like it would have been a little more work changing the format of the JSON and providing this in the header should work good.
Okay I tested this out, looks like it works fine.