Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more typed dicts to parsing #139

Merged
merged 8 commits into from
Jun 15, 2023
Merged

feat: add more typed dicts to parsing #139

merged 8 commits into from
Jun 15, 2023

Conversation

tlambert03
Copy link
Owner

adding more typing to the parsing of raw metadata

@tlambert03 tlambert03 changed the title Typed dicts feat: add more typed dicts to parsing Jun 14, 2023
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #139 (350bdf7) into main (6943a18) will decrease coverage by 0.52%.
The diff coverage is 96.95%.

❗ Current head 350bdf7 differs from pull request most recent head 28eb743. Consider uploading reports for the commit 28eb743 to get more accurate results

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   91.94%   91.43%   -0.52%     
==========================================
  Files          13       14       +1     
  Lines        1950     1949       -1     
==========================================
- Hits         1793     1782      -11     
- Misses        157      167      +10     
Impacted Files Coverage Δ
src/nd2/_pysdk/_parse.py 94.24% <94.87%> (-1.44%) ⬇️
src/nd2/_pysdk/_pysdk.py 91.05% <100.00%> (-0.04%) ⬇️
src/nd2/_pysdk/_sdk_types.py 100.00% <100.00%> (ø)
src/nd2/structures.py 93.27% <100.00%> (-2.59%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tlambert03 tlambert03 merged commit 21ce20a into main Jun 15, 2023
14 of 15 checks passed
@tlambert03 tlambert03 deleted the typed-dicts branch June 15, 2023 03:33
@tlambert03 tlambert03 added enhancement New feature or request tests Tests & CI and removed enhancement New feature or request labels Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests & CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant