Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better color object #218

Merged
merged 2 commits into from
Mar 17, 2024
Merged

feat: better color object #218

merged 2 commits into from
Mar 17, 2024

Conversation

tlambert03
Copy link
Owner

@tlambert03 tlambert03 commented Mar 17, 2024

closes #184. Metadata.channel.color is now an (r,g,b,a) tuple. If you want the original Elements integer format, use color.as_abgr_u4()

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.19%. Comparing base (d1853b0) to head (b37c434).

Files Patch % Lines
src/nd2/structures.py 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   95.25%   95.19%   -0.06%     
==========================================
  Files          18       18              
  Lines        2422     2436      +14     
==========================================
+ Hits         2307     2319      +12     
- Misses        115      117       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Mar 17, 2024

CodSpeed Performance Report

Merging #218 will not alter performance

Comparing color (b37c434) with main (d1853b0)

Summary

✅ 13 untouched benchmarks

@tlambert03 tlambert03 merged commit 53a2e1a into main Mar 17, 2024
20 of 22 checks passed
@tlambert03 tlambert03 deleted the color branch March 17, 2024 19:26
@tlambert03 tlambert03 added the enhancement New feature or request label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

todo: turn color integers into tuples (or something meaningful)
1 participant