Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _ome.py #221

Closed
wants to merge 2 commits into from
Closed

Update _ome.py #221

wants to merge 2 commits into from

Conversation

rysk-t
Copy link

@rysk-t rysk-t commented Apr 10, 2024

This change is for custom-date format like "%Y/%m/%d %H:%M:%S" (our nd2 files include such kinds of date format representing the acquisition date). This change might be for minor language user.

rysk-t and others added 2 commits April 9, 2024 16:26
for adapting custom-date format in Japan
Copy link

codspeed-hq bot commented Apr 10, 2024

CodSpeed Performance Report

Merging #221 will not alter performance

Comparing rysk-t:main (7017236) with main (706fe8d)

Summary

✅ 13 untouched benchmarks

@tlambert03
Copy link
Owner

thanks @rysk-t. can you give me a literal string example of the type of date you have in your file? I might actually upstream the fix to ome-types. but in the meantime, you also need to import datetime here for tests to pass

@tlambert03
Copy link
Owner

found a better solution for extracting datetime in #226

@rysk-t
Copy link
Author

rysk-t commented Apr 22, 2024

Thanks for your reply, and sorry for my lazy PR.
The example acquisiton-date string of our system is "2023/06/13 15:03:43".
I believe this string style is unique to the Japanese system. However, considering that the developer of the nd2 file (Nikon) is a Japanese company, the influence is not so small.

@tlambert03
Copy link
Owner

Thanks!

Actually nd2 is made by a small Czech company! https://www.lim.cz
(Contracted by Nikon of course)

They've been very helpful in general. I've got a better locale-independent source for the timestamp now, just dealing with some final issues with certain dates on windows. Will release a fix soon. Thanks again for your pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants