Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility fixes for xsdata >=24 #243

Merged
merged 7 commits into from
Feb 18, 2024
Merged

Conversation

tlambert03
Copy link
Owner

closes #242

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6f3c6ee) 86.75% compared to head (1f28b93) 86.69%.
Report is 4 commits behind head on main.

Files Patch % Lines
src/ome_types/_conversion.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
- Coverage   86.75%   86.69%   -0.06%     
==========================================
  Files          24       24              
  Lines        1200     1203       +3     
==========================================
+ Hits         1041     1043       +2     
- Misses        159      160       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 18, 2024

CodSpeed Performance Report

Merging #243 will not alter performance

⚠️ No base runs were found

Falling back to comparing fix-xsdata-release (1f28b93) with main (7246c5d)

Summary

✅ 9 untouched benchmarks

@tlambert03 tlambert03 changed the title fix: fix breakages caused by xsdata 24 fix: compatibility fixes for xsdata >=24 Feb 18, 2024
@tlambert03 tlambert03 merged commit be6d8b3 into main Feb 18, 2024
31 of 34 checks passed
@tlambert03 tlambert03 deleted the fix-xsdata-release branch February 18, 2024 23:40
@tlambert03 tlambert03 added dependencies Pull requests that update a dependency file bug Something isn't working labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError with freshly released xsdata==24.2
1 participant