Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make setting to control pass/fail criteria of each exercise #18

Closed
tlancon opened this issue May 25, 2020 · 1 comment
Closed

Make setting to control pass/fail criteria of each exercise #18

tlancon opened this issue May 25, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@tlancon
Copy link
Owner

tlancon commented May 25, 2020

Lifter may want to monitor different aspects of each lift to determine whether it was good/bad or pass/fail

For example, I would like to indicate that a snatch fails if it's below a certain peak velocity, but I want to measure squats by the time of concentric motion

This needs to react to rep reassignment when #8 is implemented

@tlancon
Copy link
Owner Author

tlancon commented May 30, 2020

Moved pf_metric and pf_criterion to each lift's metadata in lifts.json. When the table and plots are updated, pass/fail is calculated using these parameters within an f-string passed to eval. This approach makes it easy to add/remove lifts and change their criteria in the json and have the app react to it.

@tlancon tlancon closed this as completed May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant