Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE in TLAReconcilingStrategy.determineFoldingRegions when spec does not end in empty newline #414

Closed
lemmy opened this issue Jan 10, 2020 · 1 comment
Closed

NPE in TLAReconcilingStrategy.determineFoldingRegions when spec does not end in empty newline #414

lemmy opened this issue Jan 10, 2020 · 1 comment
Assignees
@quaeler
Labels
bug error, glitch, fault, flaw, ... Toolbox The TLA Toolbox/IDE
Milestone
1.7.0

Comments

@lemmy
Copy link
Member

lemmy commented Jan 10, 2020 

Exception in thread "org.eclipse.jface.text.reconciler.MonoReconciler" java.lang.NullPointerException
	at org.lamport.tla.toolbox.editor.basic.TLAReconcilingStrategy.determineFoldingRegions(TLAReconcilingStrategy.java:297)
	at org.lamport.tla.toolbox.editor.basic.TLAReconcilingStrategy.reconcile(TLAReconcilingStrategy.java:164)
	at org.lamport.tla.toolbox.editor.basic.TLAReconcilingStrategy.initialReconcile(TLAReconcilingStrategy.java:133)
	at org.eclipse.jface.text.reconciler.MonoReconciler.initialProcess(MonoReconciler.java:98)
	at org.eclipse.jface.text.reconciler.AbstractReconciler$BackgroundThread.run(AbstractReconciler.java:177)
--------------- MODULE BinaryTree ---------------
EXTENDS Sequences, Naturals

VARIABLES x

Init == /\ x = ""
       
Next == /\ \E s \in {"a", "b"} : x' = x \o s

==================================================
\* This line is NOT followed by a newline
@lemmy lemmy added bug error, glitch, fault, flaw, ... Toolbox The TLA Toolbox/IDE labels Jan 10, 2020
@lemmy lemmy added this to the 1.6.1 milestone Jan 10, 2020
quaeler added a commit that referenced this issue Jan 11, 2020
@quaeler
Ending comment without newline: bad! - #414
7d274ad 
. If a spec file had a comment on its last line, but that last line did not have a newline, an NPE was throw. No longer.

[Bug][Toolbox]
@quaeler
Copy link
Contributor

quaeler commented Jan 11, 2020

Addressed with 7d274ad

@quaeler quaeler closed this as completed Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quaeler quaeler

Labels
bug error, glitch, fault, flaw, ... Toolbox The TLA Toolbox/IDE
Projects
None yet
Milestone
1.7.0
Development

No branches or pull requests
2 participants
@lemmy @quaeler