return non-zero error codes from SANY on more errors #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended as useful when using SANY as part of shell-based tooling. The command line flag is introduced to keep it backwards compatible so that no one breaks.
lemmy
added
enhancement
lemmy
reviewed
Jul 6, 2020
| @@ -77,6 +77,10 @@ | |||
| // true <=> statistics about builtin operator usage | |||
| // should be reported | |||
|
|
|||
| private static boolean strictErrorCodes = false; | |||
There was a problem hiding this comment.
For consistency with the rest: Please rename to doStrictErrorCodes
| @@ -410,6 +418,8 @@ else if (args[i].equals("-D") || args[i].equals("-d")) | |||
| doDebugging = !doDebugging; | |||
| else if (args[i].equals("-STAT") || args[i].equals("-stat")) | |||
| doStats = !doStats; | |||
| else if (args[i].equals("-error-codes")) | |||
There was a problem hiding this comment.
I suggest to call toLowerCase on args[i] to ignore casing.
| @@ -77,6 +77,10 @@ | |||
| // true <=> statistics about builtin operator usage | |||
| // should be reported | |||
|
|
|||
| private static boolean strictErrorCodes = false; | |||
| // true <=> error level should be reported as the tools' | |||
There was a problem hiding this comment.
Please bump SANY's version number and moddate.
There was a problem hiding this comment.
Done. I believe you meant the constants towards the top of the file. Let me know if I misunderstood.
|
Thanks for the review! Made changes as requested, please take a look |
This was referenced Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended as useful when using SANY as part of shell-based
tooling. The command line flag is introduced to keep it backwards
compatible so that no one breaks.