Enable extension in browser environments #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afonsonf
changed the title
|
LGTM |
|
I will try to fix the not working features this weekend, if I'm not able to do it, I'll clean up the MR to only include the highlighting to not block it to be enabled |
afonsonf
force-pushed
the
enable-extension-in-the-web
branch
from
071a351
to
eb19a99
Compare
afonsonf
changed the title
|
Got it working, it was the document selector, for some reason in the browser it was not working for enabling the language features, so I changed it to use directly the language id strings. Also clean up the MR and removed the refactoring to have less changes |
Signed-off-by: Afonso Fernandes <21228942+afonsonf@users.noreply.github.com>
afonsonf
force-pushed
the
enable-extension-in-the-web
branch
from
eb19a99
to
3cd4d47
Compare
|
Do we have to separately add the browser-version to the VSCode marketplace? |
|
I don't think so, we can trigger the nightly release and check if the new one works |
|
Works like a charm, nicely done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, in this PR the extension is enabled for web environments such as vscode.dev and github.dev.
This is done by creating a new entrypoint for the extension where only a subset of the features is enabled, namely:
Changed to use npm compile instead of npm watch in extension debugging because to load changes the instance needs to be reload (does not reload automatically) and compile seems to work better and may solve this: #283 (comment)
References