-
Notifications
You must be signed in to change notification settings - Fork 68
Crash with Door Lock device #23
Comments
I have seen something like this while developing a ZigBee device. I believe the problem is that zigbee4java does not check if the descriptor length is zero and tries to parse it. I think I can come up with a patch, give me a few hours. |
Yes, I see the problem in the code. By the way, what lock are you working with? |
Actually I am using the sample lock from TI HA examples. And you are probably right about the length, when I debug the crash I saw that the packet length is zero. |
Well, there you go. If you look at What sort of lock are you working on? I plan to make some kind of DIY ZigBee servo actuator for my deadbolt. |
This should fix it, please test and report back. a9654de |
Thanks for your help!! |
That is a strong looking gear motor, and your part looks very nice. Here are some of my DIY ZigBee efforts: https://groups.google.com/forum/#!topic/zigbee4java/nREaHiQW42s |
Your solution fixed the bug, many thanks! |
Yes I have seen this too. If the device ID is not supported it seemingly picks a different one at random. Your device ID is 0x000A, yes? You will need to add a door lock device 0x000A, the door lock cluster 0x0101, the cluster attributes 0-6, and the two lock/unlock cluster commands. |
I added the changes to my fork: |
Hi When you are happy with your code please make a pull request and we will review and merge it to master. Best regards, |
Nice work by the way and very useful. |
Thank you for the fix @presslab-us. 👍 |
The text was updated successfully, but these errors were encountered: