This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Allow wildcard and multi domain authHost option #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in tlaverdure#195 allow for wildcard domain declaration in authHost option (e.g. authHost = '.myapp.com') so one use the laravel-echo-server with a multi tenant/subdomain system. The currently appropriate domain is retrived from the referer and matched with the wildcard domain declaration (if a wildcard is used).
tobiasvielmetter
changed the title
|
Would it be more flexible if it was regex based? Eg for multiple domains etc |
|
@barryvdh Not sure about regex. As far as my research goes: the url class is more capable to actually check the validity of the url, which I think is important when working with the referer (which can potentially be spoofed to send in a socket from another server). I think it would make sense to allow optionally an array for the authHost. So potential configurations could be: See the updated commit that covers this below at fda40bc. Let me know your thoughts. |
As described in tlaverdure#185 as well as tlaverdure#135: - allow for wildcard domain declaration in authHost option (e.g. authHost = '.myapp.com') so one can use the laravel-echo-server with a multi tenant/subdomain system - as well as a multi domain system, where different authentication servers are used. The currently appropriate authentication domain is retrived from the referer and matched with the (optional: wildcard) domain declaration from the authHost option as a whitelist (which can be either an array or a string). In case none is matched with the referer, the last one in the array is taken (in case of string, the only one). @tlaverdure @barryvdh please check. I have done my best to write this up in TS, but I don't have a compile system for this setup, so I have only tested it in vanilla JS and then afterwards added the TS specific types for this PR. Thanks!
tobiasvielmetter
changed the title
|
Thanks! |
This was referenced Jul 27, 2017
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #185 allow for wildcard domain declaration in authHost option (e.g. authHost = '.myapp.com') so one use the laravel-echo-server with a multi tenant/subdomain system. The currently appropriate domain is retrived from the referer and matched with the wildcard domain declaration (if a wildcard is used). @tlaverdure please check. Thanks!
Updated version
See comments below...