This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix checking for http via host option. #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking for which http protocol to use, the "host" option in the json file is tested to see if it starts with `https` or `http` However, if the host option DOES start with either of those, the script throws a `Error: getaddrinfo ENOTFOUND` error. See [tech info here](http://stackoverflow.com/a/17691556/659786). So removing the protocol from the `host` options means we must use something else to check for http(s). This patch uses the `protocol` option in the json file. First suggested by https://github.com/Thaars
|
Ok, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking for which http protocol to use, the "host" option in the json file is tested to see if it starts with
httpsorhttpHowever, if the host option DOES start with either of those, the script throws a
Error: getaddrinfo ENOTFOUNDerror. See tech info here.So removing the protocol from the
hostoptions means we must use something else to check for http(s). This patch uses theprotocoloption in the json file. First suggested by https://github.com/Thaars