Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moar refactor #11

Merged
merged 1 commit into from Nov 16, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
36 changes: 14 additions & 22 deletions streams/src/main/java/io/confluent/demo/StreamsDemo.java
Expand Up @@ -25,8 +25,9 @@
import java.util.Map;
import java.util.Properties;

import io.confluent.demo.util.CountAndSum;
import io.confluent.demo.util.CountAndSumDeserializer;
import io.confluent.demo.util.CountAndSumSerde;
import io.confluent.demo.util.CountAndSum;
import io.confluent.demo.util.CountAndSumSerializer;
import io.confluent.kafka.serializers.AbstractKafkaAvroSerDeConfig;
import io.confluent.kafka.streams.serdes.avro.SpecificAvroSerde;
Expand Down Expand Up @@ -152,7 +153,7 @@ protected static KTable<Long, Double> getRatingAverageTable(KStream<Long, String
KGroupedStream<Long, Double> ratingsById = ratings.mapValues(Rating::getRating).groupByKey();

/*
as per Matthias' comment https://issues.apache.org/jira/browse/KAFKA-7595?focusedCommentId=16677173&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16677173
As per Matthias' comment https://issues.apache.org/jira/browse/KAFKA-7595?focusedCommentId=16677173&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16677173
implementation

KTable<Long, Long> ratingCounts = ratingsById.count();
Expand All @@ -168,26 +169,17 @@ protected static KTable<Long, Double> getRatingAverageTable(KStream<Long, String
++aggregate.count;
aggregate.sum += value;
return aggregate;
}, Materialized.with(new LongSerde(),
new Serde<CountAndSum<Long, Double>>() {
@Override
public void configure(Map<String, ?> configs, boolean isKey) {
}

@Override
public void close() {
}

@Override
public Serializer<CountAndSum<Long, Double>> serializer() {
return new CountAndSumSerializer<>();
}

@Override
public Deserializer<CountAndSum<Long, Double>> deserializer() {
return new CountAndSumDeserializer<>();
}
})
}, Materialized.with(new LongSerde(), new CountAndSumSerde<Long, Double>() {
@Override
public Serializer<CountAndSum<Long, Double>> serializer() {
return new CountAndSumSerializer<>();
}

@Override
public Deserializer<CountAndSum<Long, Double>> deserializer() {
return new CountAndSumDeserializer<>();
}
})
);

/*KTable<Long, Double> ratingAverage = ratingSums.join(ratingCounts,
Expand Down
18 changes: 18 additions & 0 deletions streams/src/main/java/io/confluent/demo/util/CountAndSumSerde.java
@@ -0,0 +1,18 @@
package io.confluent.demo.util;

import org.apache.kafka.common.serialization.Serde;

import java.util.Map;

public abstract class CountAndSumSerde<T1, T2> implements Serde<CountAndSum<T1, T2>> {

@Override
public void configure(Map<String, ?> configs, boolean isKey) {

}

@Override
public void close() {

}
}