Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tldr-pages as copyright holder in License #108

Merged
merged 4 commits into from
Oct 16, 2021
Merged

Conversation

MasterOdin
Copy link
Contributor

This adds a new line to the license.md that recognizes that the tldr-pages organization are the current copyright holders.

I left @rubenvereecken's copyright line as the repo was originally under his account before it was transferred into the org, and it entered under the tldr-pages team's copyright.

@MasterOdin MasterOdin requested a review from sbrl October 12, 2021 09:13
@MasterOdin
Copy link
Contributor Author

MasterOdin commented Oct 12, 2021

Ideally we would also update the package.json here as well to have a new author:

tldr-lint/package.json

Lines 26 to 29 in 2825b6d

"author": {
"name": "Ruben Vereecken",
"email": "rubenvereecken@gmail.com"
},

but not sure if there's a good email address to put for the tldr org, and just leave that blank.

Secondarily, if we wish to leave credit for authorship, could just add the tldr org as a "maintainer", for example:

  "author": {
    "name": "Ruben Vereecken",
    "email": "rubenvereecken@gmail.com"
  },
  "maintainers": {
    "name": "tldr-pages team"
  }

@waldyrious
Copy link
Member

but not sure if there's a good email address to put for the tldr org, and just leave that blank.

Just dropping by to note that there's a mailing list, tldr-pages@googlegroups.com, that could be used for this purpose. It never got much (well, any) traction, and the list of enrolled people hasn't been kept up to date with tldr-pages org members, but we could certainly sync them and use it for this purpose.

@rubenvereecken
Copy link
Contributor

Appreciate the mention, I'm happy to be taken out completely. This project has long outlived my close involvement and happy to see it.

@MasterOdin
Copy link
Contributor Author

I went with just putting the author name and omitting the email address. Probably not a thing to worry about.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MasterOdin!

@sbrl
Copy link
Member

sbrl commented Oct 16, 2021

Hmmm, seems like we can't merge this due to conflicts.

@owenvoke
Copy link
Member

@sbrl, I don't see any conflicts when going to merge. 🤔

@MasterOdin MasterOdin merged commit b144f62 into main Oct 16, 2021
@MasterOdin MasterOdin deleted the MasterOdin-patch-2 branch October 16, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants