Use 'npm run test:all' in .travis.yml to also check lint error #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2017
Closed
|
All test matrix are failed as intended, as the master code contains lint error. After the master code fixed by merging #131, and this PR rebased, the tests should pass. |
Signed-off-by: Tao Wang <twang2218@gmail.com>
twang2218
force-pushed
the
test-all-in-travis
branch
from
fa026af
to
161a393
Compare
4 tasks
|
Closing this in favor of #132. Rebased from master and created a new PR. @twang2218 - your commit history is maintained. |
|
@agnivade Cool, 👍 you are really fast, I was just rebasing. 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in #128 , the
.travis.ymldidn't checklinterror, and cause the error code bypass the localprecommithooks into the repo if localeslintor other dependencies are outdated or have problem.I replaced
npm test && npm run test:functionalwithnpm run test:allto testlintas well.Checklist
Please review this checklist before submitting a pull request.
npm run test:all)Signed-off-by: Tao Wang twang2218@gmail.com