Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show english page when no page is found for the current locale #138

Closed
Roboron3042 opened this issue Aug 30, 2020 · 4 comments
Closed

Show english page when no page is found for the current locale #138

Roboron3042 opened this issue Aug 30, 2020 · 4 comments

Comments

@Roboron3042
Copy link

It's so confusing to search for a tldr and get not results for commands you know it's sure they have one. Until you notice it's only showing you results on your current locale...

I suggest tldr to show the english page when no page is found for your current locale. It is a saner default, and it is was man does, for example.

@samuel-w
Copy link
Contributor

samuel-w commented Aug 31, 2020

What's the client, because per the specification:

In order to determine the display language, a client MUST:
...
Fall back to English if none of the languages are available.

and

Regardless of the language determined through the environment, clients MUST always attempt to fallback to English if the page does not exist in the user preferred language.

@Roboron3042
Copy link
Author

It's the tldr client available from arch repos, which seems to be python.

If I try again to search for the same page, it works as expected. But I guess it it because it is cached now. If I try a new one, it fails again.

@sbrl sbrl transferred this issue from tldr-pages/tldr Sep 4, 2020
@sbrl
Copy link
Member

sbrl commented Sep 4, 2020

Hey there, @Roboron3042! You mentioned that you're using the tldr python client.

tldr-pages/tldr is only for the tldr pages themselves, rather than the clients. I've transferred your issue over to the tldr-pages/tldr-python-client repo :-)

/cc @MasterOdin, and maybe @zdroid

@MasterOdin
Copy link
Collaborator

Yup, with tldr-pages/tldr#4246 merged which makes this behavior part of the specification, this will be part of the next python release, which I hope to cut in the next week or so.

This behavior though was implemented in #123, and is available on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants