Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to change language using a client? #3161

Closed
liuhaojava opened this issue Jul 2, 2019 · 4 comments
Closed

How to change language using a client? #3161

liuhaojava opened this issue Jul 2, 2019 · 4 comments
Labels
clients Issues pertaining to a particular client or the clients as whole.

Comments

@liuhaojava
Copy link

liuhaojava commented Jul 2, 2019

How to Change Language?

@waldyrious waldyrious added the clients Issues pertaining to a particular client or the clients as whole. label Jul 2, 2019
@waldyrious
Copy link
Member

waldyrious commented Jul 2, 2019

According to the client spec, it is expected that clients will determine what language to show based on the environment variables such as LANG.

@sbrl, wouldn't it make sense to also recommend a --lang or --language CLI argument to switch the language, just like we have --platform to override the auto-detected operating system?

(By the way, maybe we should define versioning for the spec, so that clients can indicate to users exactly what version they support and remain compliant even when future changes to the spec are introduced. What do you guys think?) Silly me, that's already in place.

@mebeim
Copy link
Member

mebeim commented Jul 2, 2019

Hi @liuhaojava, it depends on which client you are currently using. Not many clients support changing language or identifying language at all as of now. The only one which I am aware of is elecprog/tldr. As @waldyrious said, clients should be following the specification, but that's a rather new addition and clients did't have much time to catch up.

@sbrl
Copy link
Member

sbrl commented Jul 3, 2019

@waldyrious Thinking about it, it absolutely would (though you can always do LANG=abc tldr example, but that feels a bit weird). Have any clients actually added multi-language support yet? I think our reference node client is notably lacking support. We've got quite a selection of translated pages to test with now.

I'll open a PR to update the client spec.

Maybe it's worth @mentioning client authors in the PR to make them aware of it.

@mebeim mebeim changed the title How to Change Language? How to change language using a client? Jul 5, 2019
@agnivade
Copy link
Member

agnivade commented Jul 9, 2019

@liuhaojava - I am going to close this now as your question has been answered. If you want details on a specific client, please feel free to open an issue in that client's repo. Thanks.

@agnivade agnivade closed this as completed Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clients Issues pertaining to a particular client or the clients as whole.
Projects
None yet
Development

No branches or pull requests

5 participants