Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collaborator: @ivanhercaz #3690

Closed
zlatanvasovic opened this issue Dec 24, 2019 · 5 comments · Fixed by #3691
Closed

Add collaborator: @ivanhercaz #3690

zlatanvasovic opened this issue Dec 24, 2019 · 5 comments · Fixed by #3691
Labels
community Issues/PRs dealing with role changes and community organization.

Comments

@zlatanvasovic
Copy link
Contributor

zlatanvasovic commented Dec 24, 2019

Hi, @ivanhercaz! You seem to be enjoying contributing to the tldr-pages project.
You now have had five distinct pull requests merged (#3669, #3682, #3670, #3675, #3680)!
That qualifies you to become a collaborator in this repository, as explained in our community roles documentation.

As a collaborator, you will have commit access to the repository.
That means you can merge pull requests, label and close issues, and perform various other maintenance tasks that are needed here and there.
Of course, all of this is voluntary — you're welcome to contribute to the project in whatever ways suit your liking.

If you do decide to start performing maintenance tasks, though, we only ask you to get familiar with the maintainer's guide.

So, what do you say? Can we add you as a collaborator?

Either way, thanks for all your work so far!

zlatanvasovic added a commit that referenced this issue Dec 24, 2019
@sbrl
Copy link
Member

sbrl commented Dec 24, 2019

Oops, looks like you missed the links to the relevant PRs here @zdroid :P

@zlatanvasovic
Copy link
Contributor Author

They're already there in the commit list. :P
#3669 #3682 #3670 #3675 #3680

@ivanhercaz
Copy link
Collaborator

@zdroid, for me it is a pleasure to accept your invitation and be a collaborator in this awesome and useful project. Thank you for this proposal. I am really happy to be part of this project as collaborator.

@waldyrious
Copy link
Member

They're already there in the commit list. :P

Do you mean here? https://github.com/tldr-pages/tldr/commits?author=ivanhercaz

Note that these issues are meant to serve as historical record for the role changes, so a dynamic listing will not work well for that purpose. (Also, the message looks rather unfinished with placeholder text left in!)

I've added the links you mentioned to the opening comment. Next time please do so when creating the issue. 🙂

@Geipro Geipro added the community Issues/PRs dealing with role changes and community organization. label Dec 26, 2019
@zlatanvasovic
Copy link
Contributor Author

@waldyrious Oh you're right. I didn't notice that part of the template was left unedited.

zlatanvasovic added a commit that referenced this issue Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues/PRs dealing with role changes and community organization.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants