New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coursier: add new documentation pages #9728
coursier: add new documentation pages #9728
Conversation
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mandatory fixes found, changes requested.
Just first 3 pages were reviewed.
Thanks for a contribution! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, after all, @EmilySeville7cfg's suggestions are addressed.
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
I'll continue reviewing tomorrow. :) |
Thank you for your time @EmilySeville7cfg! |
d573b5e
to
4442145
Compare
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mandatory fixes found, changes requested.
Thanks for a contribution! ❤️
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
could it be merged now in your opinion? If yes, could you mark the comment as resolved? |
common
,linux
,osx
,windows
,sunos
,android
, etc.