Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coursier: add new documentation pages #9728

Merged

Conversation

eliax1996
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • v2.1.0-RC4

@CLAassistant
Copy link

CLAassistant commented Jan 5, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Jan 5, 2023
@tldr-bot
Copy link

tldr-bot commented Jan 5, 2023

The build for this PR failed with the following error(s):

pages/common/cs-resolve.md:28:183 MD047/single-trailing-newline Files should end with a single newline character
pages/common/cs-fetch.md:
Error: Parse error on line 13:
...:latest.release)"``- Fetch the source 
----------------------^
Expecting 'BACKTICK', 'COMMAND_TEXT', 'COMMAND_TOKEN', got 'NEWLINE'
pages/common/cs-java.md:29: TLDR011 Page never contains more than a single empty line
pages/common/cs-resolve.md:1: TLDR009 Page should contain a newline at end of file

Please fix the error(s) and push again.

@tldr-bot
Copy link

tldr-bot commented Jan 5, 2023

The build for this PR failed with the following error(s):

pages/common/cs-java.md:29: TLDR011 Page never contains more than a single empty line

Please fix the error(s) and push again.

@kbdharun kbdharun added the review needed Prioritized PRs marked for reviews from maintainers. label Jan 6, 2023
Copy link
Contributor

@EmilyGraceSeville7cf EmilyGraceSeville7cf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mandatory fixes found, changes requested.
Just first 3 pages were reviewed.
Thanks for a contribution! 🚀

pages/common/cs-complete-dep.md Outdated Show resolved Hide resolved
pages/common/cs-complete-dep.md Outdated Show resolved Hide resolved
pages/common/cs-complete-dep.md Outdated Show resolved Hide resolved
pages/common/cs-fetch.md Outdated Show resolved Hide resolved
pages/common/cs-fetch.md Outdated Show resolved Hide resolved
pages/common/cs-install.md Outdated Show resolved Hide resolved
pages/common/cs-install.md Outdated Show resolved Hide resolved
pages/common/cs-install.md Outdated Show resolved Hide resolved
pages/common/cs-install.md Outdated Show resolved Hide resolved
pages/common/cs-install.md Outdated Show resolved Hide resolved
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after all, @EmilySeville7cfg's suggestions are addressed.

eliax1996 and others added 15 commits January 6, 2023 17:06
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
@EmilyGraceSeville7cf
Copy link
Contributor

I'll continue reviewing tomorrow. :)

@eliax1996
Copy link
Contributor Author

Thank you for your time @EmilySeville7cfg!

@eliax1996 eliax1996 force-pushed the create-coursier-documentation branch from d573b5e to 4442145 Compare January 6, 2023 16:32
eliax1996 and others added 9 commits January 7, 2023 10:49
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
@tldr-bot
Copy link

tldr-bot commented Jan 7, 2023

The build for this PR failed with the following error(s):

pages/common/cs-resolve.md:21 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Print all the libraries that..."]
pages/common/cs-resolve.md:21: TLDR007 Example descriptions should be surrounded by empty lines

Please fix the error(s) and push again.

@tldr-bot
Copy link

tldr-bot commented Jan 7, 2023

The build for this PR failed with the following error(s):

pages/common/cs-resolve.md:21 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Print all the libraries that..."]
pages/common/cs-resolve.md:21: TLDR007 Example descriptions should be surrounded by empty lines

Please fix the error(s) and push again.

@tldr-bot
Copy link

tldr-bot commented Jan 7, 2023

The build for this PR failed with the following error(s):

pages/common/cs-resolve.md:21 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Print all the libraries that..."]
pages/common/cs-resolve.md:21: TLDR007 Example descriptions should be surrounded by empty lines

Please fix the error(s) and push again.

eliax1996 and others added 2 commits January 7, 2023 10:50
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
@tldr-bot
Copy link

tldr-bot commented Jan 7, 2023

The build for this PR failed with the following error(s):

pages/common/cs-resolve.md:21 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Print all the libraries that..."]
pages/common/cs-resolve.md:21: TLDR007 Example descriptions should be surrounded by empty lines

Please fix the error(s) and push again.

@tldr-bot
Copy link

tldr-bot commented Jan 7, 2023

The build for this PR failed with the following error(s):

pages/common/cs-resolve.md:21 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Print all the libraries that..."]
pages/common/cs-resolve.md:21: TLDR007 Example descriptions should be surrounded by empty lines

Please fix the error(s) and push again.

@EmilyGraceSeville7cf EmilyGraceSeville7cf dismissed their stale review January 7, 2023 10:29

Incorrect review outcome

Copy link
Contributor

@EmilyGraceSeville7cf EmilyGraceSeville7cf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mandatory fixes found, changes requested.
Thanks for a contribution! ❤️

pages/common/cs-java.md Outdated Show resolved Hide resolved
pages/common/cs-resolve.md Outdated Show resolved Hide resolved
eliax1996 and others added 2 commits January 9, 2023 16:36
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
Co-authored-by: Emily Grace Seville <EmilySeville7cfg@gmail.com>
@tldr-bot
Copy link

tldr-bot commented Jan 9, 2023

The build for this PR failed with the following error(s):

pages/common/cs-resolve.md:21 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Print all the libraries that..."]
pages/common/cs-resolve.md:21: TLDR007 Example descriptions should be surrounded by empty lines

Please fix the error(s) and push again.

@tldr-bot
Copy link

tldr-bot commented Jan 9, 2023

The build for this PR failed with the following error(s):

pages/common/cs-resolve.md:21 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Print all the libraries that..."]
pages/common/cs-resolve.md:21: TLDR007 Example descriptions should be surrounded by empty lines

Please fix the error(s) and push again.

@eliax1996
Copy link
Contributor Author

Mandatory fixes found, changes requested. Thanks for a contribution! ❤️

could it be merged now in your opinion? If yes, could you mark the comment as resolved?
Thank you again for the awesome review

@EmilyGraceSeville7cf EmilyGraceSeville7cf merged commit 1616fd5 into tldr-pages:main Jan 9, 2023
@eliax1996 eliax1996 deleted the create-coursier-documentation branch January 9, 2023 16:46
@pixelcmtd pixelcmtd removed the review needed Prioritized PRs marked for reviews from maintainers. label Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants