New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mongorestore: add page #1037
mongorestore: add page #1037
Conversation
Solid entry, nice work! The only thing I'd change is "containing bson data dump" --> "containing a bson data dump". |
|
||
> Utility to import a collection or database from a binary dump into a MongoDB instance. | ||
|
||
- Import database from folder containing a bson data dump: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The language can be improved a bit. Its not very clear that the data is being imported "to" the database. I would love a "from" -> "to" sentence. How about "Import a bson data dump from a folder to a given database" ?
A couple of points -
|
Agree with most of the points. I feel --collection option for mongorestore need not be included here as it is rarely used ( such as collection name conflicts that will arise only if an exisiting database is merged with dump from another database). |
|
||
- Import a bson data dump from a folder to a mongodb instance: | ||
|
||
`mongorestore --host {{database_host}} --port {{port}} --db {{database_name}} {{path/to/folder}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel --host
and --port
can be dropped here since they are anyways used in the next examples. Lets lay it slowly on the user 😄
LGTM from my side. Over to @waldyrious for any final comments. |
|
||
`mongorestore --db {{database_name}} {{path/to/folder}}` | ||
|
||
- Import a bson data dump from a folder to a given mongodb database host running at a given port with user authentication; user will be prompted for password: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit of a mouthful. We should harness punctuation to better guide reading flow, e.g.
- Import a bson data dump from a folder to a given mongodb database host, running at a given port, with user authentication (user will be prompted for password):
I've left some (mostly minor) inline comments. Additionally, I would suggest the "MongoDB" capitalization to be used in all descriptions, for correctness and to match the form used in the command summary. |
I'm happy with how the page turned out. Thanks again for a great contribution! |
No description provided.