Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ionic: add page #1137

Closed
wants to merge 1 commit into from
Closed

ionic: add page #1137

wants to merge 1 commit into from

Conversation

jobinlawrance
Copy link

@jobinlawrance jobinlawrance commented Oct 30, 2016

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2016

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@agnivade agnivade changed the title add ionic page ionic: add page Oct 31, 2016
@agnivade agnivade added the new command Issues requesting creation of a new page. label Oct 31, 2016
Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, kindly fix the travis errors-

Error: Parse error on line 11:
...t {{{project_name}}`  `- Create a new 
-----------------------^
Expecting 'NEWLINE', 'TEXT', 'DASH', 'BACKTICK', got 'COMMAND_TEXT'
pages/common/ionic.md:3: TLDR004 Command descriptions should end in a period
pages/common/ionic.md:5: TLDR005 Example descriptions should end in a colon
pages/common/ionic.md:9: TLDR005 Example descriptions should end in a colon
pages/common/ionic.md:10: TLDR103 Command example is missing its closing backtick


> Complete open source SDK to build top quality native and progressive web apps using Angular JS and Apache Cordova.

- Installation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tldr is a man page alternative. So no need to provide installation steps.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, it's not about need (beginners would certainly welcome help with installation), but about scope: we have very limited space due to our commitment to provide short pages, and we focus on usage documentation; installation instructions (which often can be quite exhaustive to support multiple platforms, package managers, etc.) can clash with these goals, so we choose not to include them for any of the tools we cover. I hope you can understand :)


- Create a new project with a local template

`ionic start {{project_name}} {{~/path/to/template}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{{~/path/to/template}} => {{path/to/template}}


`ionic start {{project_name}} {{codepen_url}}`

- Viewing the app in a browser
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Viewing the app" => "View the app"


`ionic start {{project_name}} {{~/path/to/template}}`

- Create project using template on GitHub
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create "a" project

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the same vein, "using a template".


`ionic start {{project_name}} {{username}}/{{repo}}`

- Create project using template on Codepen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create "a" project

@@ -0,0 +1,31 @@
# ionic

> Complete open source SDK to build top quality native and progressive web apps using Angular JS and Apache Cordova.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tend to omit adjectives ("complete", "open source", "top quality") in the main description. Stick to describing what it is and what it does :)

Btw, "progressive web app" (PWA) seems to be kind of a specialized term, which is explained even to ionic users. I think it's not generic/informative enough to be included here. Maybe "top quality native and progressive web apps" --> "native-like mobile web apps"?

@waldyrious waldyrious added the waiting Issues/PRs with Pending response by the author. label Dec 21, 2016
@agnivade
Copy link
Member

agnivade commented Jan 2, 2017

@jobinlawrance - any updates on this ?

@agnivade
Copy link
Member

agnivade commented Feb 24, 2017

Hi @jobinlawrance - Please sign the CLA so that we can move forward on this PR. I am closing this one after getting no response from you. Feel free to reopen this anytime, and we can resume our work on it !

@agnivade agnivade closed this Feb 24, 2017
@waldyrious
Copy link
Member

@jobinlawrance if you have any objections regarding the CLA, we are also open to hear them :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page. waiting Issues/PRs with Pending response by the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants