Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmus: add page #1204

Merged
merged 3 commits into from Jan 2, 2017
Merged

cmus: add page #1204

merged 3 commits into from Jan 2, 2017

Conversation

alefir
Copy link

@alefir alefir commented Dec 18, 2016

Addresses #1162 for cmus
Currently in pages/linux because I'm not sure if other operating systems have different commands.

# cmus

> Commandline C* Music Player.
> Arrow keys to navogate, `<enter/return>` to select, numbers 1-8 switch between different views.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "navogate". Also, please start the sentence with "Use...", and add "and" before "numbers".

@@ -0,0 +1,24 @@
# cmus

> Commandline C* Music Player.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C* is a somewhat obscure term IMO. Does it mean C/C++, or something else?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C* comes from the package description.
It was written in C and C++, and I think the * is being used as a regex-style wildcard.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could just remove it. It's not really relevant to know what language a tool is written in, and here I'm afraid it just add noise.


- Pause/unpause current song:

`c`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the "c" stand for anything in particular?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's there just because there are some similar commands in the same area of the keyboard (b is next song)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. It would be nice if we could come up with a nice mnemonic for it, even if it isn't the original meaning (if any). But that would be just a bonus :) it definitely won't hold up merging.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example: "Cease/continue playing the current song" (I know, "cease" is kind of a stretch, but it's technically correct :P)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant think of anything that would make much sense.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this one is hard. Don't worry about it.


`s`

- Close cmus:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "quit" instead of "close", so that the association with "q" can be more readily made.


`c`

- Toggle shuffle:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This phrasing is slightly awkward. How about "Toggle shuffling of songs"?

@waldyrious waldyrious added the new command Issues requesting creation of a new page. label Dec 18, 2016
@waldyrious
Copy link
Member

LGTM 👍

Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👍

@agnivade agnivade merged commit 084acff into tldr-pages:master Jan 2, 2017
@waldyrious
Copy link
Member

Thanks for the contribution and the patience @alefir :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants