New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
objcopy: add page #12754
objcopy: add page #12754
Conversation
sorry for taking 4 commits, i was unable to test it locally |
No problem, it's absolutely normal to edit an already added page, the additional commits won't clutter the repository commit tree because they are squashed in a single commit. For the next times, please follow the recommended templates for commit messages (the same as the PR template messages). As for your case (modification of a single page), basically we have two recommended templates:
Or:
But no need to apologize! It's your first contribution after all, and I really appreciate your initiative to write this page and open a PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your page is very good, it contains concise and interesting examples.
LGTM after we address some minor issues I raised.
pages/linux/objcopy.md
Outdated
@@ -0,0 +1,24 @@ | |||
# objcopy | |||
|
|||
> The GNU objcopy utility copies the contents of an object file to another. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> The GNU objcopy utility copies the contents of an object file to another. | |
> Copy the contents of an object file to another. |
The style guide recommends concise (without any sort of "the GNU foobar command, that is available for Windows, macOS and Linux..." text) page descriptions that directly answers what you can do (imperative mood) with the command.
pages/linux/objcopy.md
Outdated
|
||
- Copy data to another file: | ||
|
||
`objcopy {{/your/path/to/file/src}} {{/your/path/to/file/destination}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`objcopy {{/your/path/to/file/src}} {{/your/path/to/file/destination}}` | |
`objcopy {{path/to/source_file}} {{path/to/target_file}}` |
The style guide recommends:
- Starting placeholders for absolute path arguments with "/" and not starting with "/" for relative path arguments
- File placeholders in the form "{{path/to/file}}", where file can be relaced with a more descriptive name
pages/linux/objcopy.md
Outdated
|
||
- Translate object files from one format to another: | ||
|
||
`objcopy --input-target={{inputformat}} --output-target={{output_format}} {{/path/to/your/src}} {{path/to/your/destination}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`objcopy --input-target={{inputformat}} --output-target={{output_format}} {{/path/to/your/src}} {{path/to/your/destination}}` | |
`objcopy --input-target={{inputformat}} --output-target={{output_format}} {{path/to/source_file}} {{path/to/destination_file}}` |
See #12754 (comment).
pages/linux/objcopy.md
Outdated
|
||
- Strip all symbol information from file: | ||
|
||
`objcopy --strip-all {{/path/to/your/src}} {{path/to/your/destination}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`objcopy --strip-all {{/path/to/your/src}} {{path/to/your/destination}}` | |
`objcopy --strip-all {{path/to/source_file}} {{path/to/destination_file}}` |
See #12754 (comment).
pages/linux/objcopy.md
Outdated
|
||
- Strip debugging information from file: | ||
|
||
`objcopy --strip-debug {{/path/to/your/src}} {{path/to/your/destination}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`objcopy --strip-debug {{/path/to/your/src}} {{path/to/your/destination}}` | |
`objcopy --strip-debug {{path/to/source_file}} {{path/to/destination_file}}` |
See #12754 (comment).
pages/linux/objcopy.md
Outdated
|
||
- Copy a specific section from the source to destination: | ||
|
||
`objcopy --only-section={{section}} {{/path/to/your/src}} {{path/to/your/destination}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`objcopy --only-section={{section}} {{/path/to/your/src}} {{path/to/your/destination}}` | |
`objcopy --only-section={{section}} {{/path/to/source_file}} {{path/to/destination_file}}` |
See #12754 (comment).
pages/linux/objcopy.md
Outdated
|
||
`objcopy --input-target={{inputformat}} --output-target={{output_format}} {{/path/to/your/src}} {{path/to/your/destination}}` | ||
|
||
- Strip all symbol information from file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Strip all symbol information from file: | |
- Strip all symbol information from a specific file: |
pages/linux/objcopy.md
Outdated
> The GNU objcopy utility copies the contents of an object file to another. | ||
> More information: <https://manned.org/objcopy>. | ||
|
||
- Copy data to another file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Copy data to another file: | |
- Copy all data from a specific file to another one: |
pages/linux/objcopy.md
Outdated
|
||
`objcopy --strip-debug {{/path/to/your/src}} {{path/to/your/destination}}` | ||
|
||
- Copy a specific section from the source to destination: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Copy a specific section from the source to destination: | |
- Copy a specific section of the source file to the destination file: |
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
common
,linux
,osx
,windows
,sunos
,android
, etc.