New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
write: add page #1577
write: add page #1577
Conversation
Please give an '.md' extension to the page. And also, we have maximum of 2 lines of the heading. So, please remove one line, choose whichever is the least important. After that, we can get started with the review. |
Updated page as requested |
The build for this PR has failed with the following error(s):
Please fix the error(s) and push again. |
- Simplify heading and made who command within backticks - Simplified some command descriptions.
Hi @pollev, I have made some simplifications which I think makes the page more succinct and clean. Let me know what you think. |
Looks great! |
Now that everything is approved, how do I actually merge? |
@pollev Once a maintainer has approved your PR, a second maintainer (such as myself!) will then come along and merge 😺 |
There you go :D |
[OK] The page (if new), does not already exist in the repo.
[OK] The page (if new), has been added to the correct platform folder:
common/
if it's common to all platforms,linux/
if it's Linux-specific, and so on.[OK] The page has 8 or fewer examples.
[OK] The PR is appropriately titled:
<command name>: add page
for new pages, or<command name>: <description of changes>
for pages being edited[OK] The page follows the contributing guidelines