Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write: add page #1577

Merged
merged 4 commits into from Oct 26, 2017
Merged

write: add page #1577

merged 4 commits into from Oct 26, 2017

Conversation

pollev
Copy link
Contributor

@pollev pollev commented Oct 25, 2017


  • [OK] The page (if new), does not already exist in the repo.

  • [OK] The page (if new), has been added to the correct platform folder:
    common/ if it's common to all platforms, linux/ if it's Linux-specific, and so on.

  • [OK] The page has 8 or fewer examples.

  • [OK] The PR is appropriately titled:
    <command name>: add page for new pages, or <command name>: <description of changes> for pages being edited

  • [OK] The page follows the contributing guidelines

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2017

CLA assistant check
All committers have signed the CLA.

@sbrl sbrl added the new command Issues requesting creation of a new page. label Oct 25, 2017
@agnivade
Copy link
Member

Please give an '.md' extension to the page.

And also, we have maximum of 2 lines of the heading. So, please remove one line, choose whichever is the least important.

After that, we can get started with the review.

@pollev
Copy link
Contributor Author

pollev commented Oct 26, 2017

Updated page as requested

@tldr-bot
Copy link

The build for this PR has failed with the following error(s):

pages/linux/write.md:3: TLDR004 Command descriptions should end in a period
pages/linux/write.md:4: TLDR004 Command descriptions should end in a period
pages/linux/write.md:10: TLDR003 Descriptions should start with a capital letter
pages/linux/write.md:10: TLDR005 Example descriptions should end in a colon
pages/linux/write.md:14: TLDR003 Descriptions should start with a capital letter
pages/linux/write.md:14: TLDR005 Example descriptions should end in a colon

Please fix the error(s) and push again.

pollev and others added 2 commits October 26, 2017 10:29
- Simplify heading and made who command within backticks
- Simplified some command descriptions.
@agnivade
Copy link
Member

Hi @pollev, I have made some simplifications which I think makes the page more succinct and clean. Let me know what you think.

@pollev
Copy link
Contributor Author

pollev commented Oct 26, 2017

Looks great!

@pollev
Copy link
Contributor Author

pollev commented Oct 26, 2017

Now that everything is approved, how do I actually merge?

@sbrl
Copy link
Member

sbrl commented Oct 26, 2017

@pollev Once a maintainer has approved your PR, a second maintainer (such as myself!) will then come along and merge 😺

@sbrl sbrl merged commit 9a73c2d into tldr-pages:master Oct 26, 2017
@sbrl
Copy link
Member

sbrl commented Oct 26, 2017

There you go :D

@pollev pollev deleted the patch-1 branch October 27, 2017 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants