fallocate: add page #2089
Merged
fallocate: add page #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrl
reviewed
May 5, 2018
There was a problem hiding this comment.
Cool! Thanks for the page, @fuerbringer 😺
Just a few quick notes for you to review below :-)
pages/linux/fallocate.md
Outdated
|
|
||
| - Deallocate 20MB of space after 100MB in a file: | ||
|
|
||
| `fallocate --collapse-range --offset 100M --length 20M {{path/to/file}}` |
There was a problem hiding this comment.
Perhaps put 100M and 20M in {{ and }}?
pages/linux/fallocate.md
Outdated
|
|
||
| - Reserve a file taking up 700MB of disk space: | ||
|
|
||
| `fallocate --length 700M {{path/to/file}}` |
agnivade
requested changes
May 6, 2018
pages/linux/fallocate.md
Outdated
|
|
||
| `fallocate --collapse-range --length {{200M}} {{path/to/file}}` | ||
|
|
||
| - Deallocate 20MB of space after 100MB in a file: |
There was a problem hiding this comment.
Should it be "Shrink" instead of "Deallocate" ? The command looks the same to me. It's just that here it is happening at an offset whereas the previous one shrinks from the end of the file. The description should be consistent in both cases.
sbrl
approved these changes
May 6, 2018
There was a problem hiding this comment.
Looks ok to me! Once @agnivade's comment is dealt with, I think we can merge this. Thanks again, @fuerbringer! 😺
agnivade
approved these changes
May 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux-specific command line tool to allocate sparse files. Useful for allocating VM images or dummy files without "wasting" write cycles.
The page (if new), does not already exist in the repo.
The page (if new), has been added to the correct platform folder:
common/if it's common to all platforms,linux/if it's Linux-specific, and so on.The page has 8 or fewer examples.
The PR is appropriately titled:
<command name>: add pagefor new pages, or<command name>: <description of changes>for pages being edited.The page follows the contributing guidelines.