mpv: add page #2314
mpv: add page #2314
Conversation
|
|
|
@mortenfyhn Dude this is so awesome! Could use a few more examples tho =] |
|
Yeah, I know only mentioning Any input on my keyboard shortcut question? |
|
The build for this PR has failed with the following error(s): Please fix the error(s) and push again. |
pages/common/mpv.md
Outdated
| @@ -9,3 +9,7 @@ | |||
| - Play a video at specified speed (0.01 to 100, default 1): | |||
|
|
|||
| `mpv --speed {{speed}} {{video_file}}` | |||
|
|
|||
| - Play a video using a profile defined in your `mpv.conf` file: | |||
There was a problem hiding this comment.
How about we drop the your.
'Play a video using a profile defined in mpv.conf file:'
There was a problem hiding this comment.
I don't really agree, because the user has to define his own mpv.conf file. I could write 'in the mpv.conf' file, but that would make it sound like it already exists.
There was a problem hiding this comment.
I think this is fine as-is here, as the mpv.conf file is likely to be in the user's own home directory.
There was a problem hiding this comment.
FYI - We try to avoid personal pronouns and aim to keep the language impersonal. If you want to keep your, I would suggest one's or something similar which makes it sound impersonal.
There was a problem hiding this comment.
I've pushed a new one using the, I think it reads better than one's.
|
@mortenfyhn Thank you for the PR. If you want to add shortcuts which you think are useful, you could have a look at |
|
The build for this PR has failed with the following error(s): Please fix the error(s) and push again. |
|
Thanks! |
The page (if new), does not already exist in the repo.
The page (if new), has been added to the correct platform folder:
common/if it's common to all platforms,linux/if it's Linux-specific, and so on.The page has 8 or fewer examples.
The PR is appropriately titled:
<command name>: add pagefor new pages, or<command name>: <description of changes>for pages being edited.The page follows the contributing guidelines.
Thought this could be useful for some. Is there a specific style for keyboard shortcuts that can be used while the command/program runs? mpv accepts a bunch of shortcuts while playing video, and some of those would be nice to add to the tldr page, but I'm not sure if that's a) something you want in the tldr pages, and b) what syntax to use for that.