Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate first 6 windows pages in Brazilian Portuguese #2727

Merged
merged 9 commits into from
Feb 5, 2019
Merged

Translate first 6 windows pages in Brazilian Portuguese #2727

merged 9 commits into from
Feb 5, 2019

Conversation

schneiderl
Copy link
Collaborator

Translated first six windows pages in Portuguese.
List:
cls.md
cmd.md
dir.md
mkdir.md
print.md
type.md

@sbrl sbrl added the translation Translate pages from one language to another. label Jan 23, 2019
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @schneiderl 😺

@waldyrious / @agnivade, is the language code formatted correctly? I think this is the first one we've got that uses a double-part language code.

@schneiderl
Copy link
Collaborator Author

Hi @sbrl

According to the Contributing Guidelines for translation introduced on #2703 language codes should follow BCP 47, just as it is with the files included on this PR.

@agnivade
Copy link
Member

Yes, language code is correct. Will leave it to @waldyrious to review.

@waldyrious
Copy link
Member

Sorry guys, I've been going through some pretty busy times lately.

@schneiderl, many thanks for the PR! I've added some comments inline, but overall this looks pretty good! Should be ready to merge once the comments are resolved :)

@schneiderl
Copy link
Collaborator Author

Hi @waldyrious ,
I have resolved your comments and it should be good now. :)

@waldyrious
Copy link
Member

One last nitpick :)

Co-Authored-By: schneiderl <casdpa@gmail.com>
@schneiderl
Copy link
Collaborator Author

One last nitpick :)

Oh, did not saw that.
Thank you @waldyrious

@waldyrious
Copy link
Member

Great, thanks so much for the PR and quick updates :) Given that there's already been two other approvals, I'll go ahead and merge.

@waldyrious waldyrious merged commit 250808d into tldr-pages:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants