Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lslocks: add page #3037

Merged
merged 7 commits into from
May 28, 2019
Merged

lslocks: add page #3037

merged 7 commits into from
May 28, 2019

Conversation

RH-sdavey
Copy link
Contributor

Part of #2214

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.

@CLAassistant
Copy link

CLAassistant commented May 17, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@mebeim mebeim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RH-sdavey, thank you for your contribution! I added some comments for you to review below. I'd like to emphasize the fact that the --pid and --json options are not showed in any example. Let me know if there's any problem or if you need any help 🙂

pages/linux/lslocks.md Outdated Show resolved Hide resolved
pages/linux/lslocks.md Outdated Show resolved Hide resolved
pages/linux/lslocks.md Outdated Show resolved Hide resolved
pages/linux/lslocks.md Outdated Show resolved Hide resolved
pages/linux/lslocks.md Outdated Show resolved Hide resolved
@mebeim mebeim added the new command Issues requesting creation of a new page. label May 17, 2019
RH-sdavey and others added 5 commits May 20, 2019 09:20
Co-Authored-By: Marco Bonelli <mebeim@users.noreply.github.com>
Co-Authored-By: Marco Bonelli <mebeim@users.noreply.github.com>
Co-Authored-By: Marco Bonelli <mebeim@users.noreply.github.com>
Co-Authored-By: Marco Bonelli <mebeim@users.noreply.github.com>
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we ready to merge, @mebeim?


- List locks with defined column headers:

`lslocks --output PID,COMMAND,PATH`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should PID,COMMAND,PATH be within tokens ({{}}) ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it should.

Copy link
Member

@mebeim mebeim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me after @agnivade's comment is taken care of.

@RH-sdavey
Copy link
Contributor Author

Changes made, thanks for merge, will add more updates/new pages later this week.

@agnivade agnivade merged commit f25dd60 into tldr-pages:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants