Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f3probe: add page #3039

Merged
merged 3 commits into from May 19, 2019
Merged

f3probe: add page #3039

merged 3 commits into from May 19, 2019

Conversation

sbrl
Copy link
Member

@sbrl sbrl commented May 18, 2019

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@sbrl sbrl added the new command Issues requesting creation of a new page. label May 18, 2019
Aracki
Aracki reviewed May 18, 2019
View reviewed changes
Copy link
Collaborator

@Aracki Aracki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding flags like --destructive and/or --time-ops?

@sbrl
Copy link
Member Author

sbrl commented May 19, 2019

Good idea, @Aracki! I didn't initially want to add --destructive though, since it, well, destroys pre-existing data on the device.

@tldr-bot
Copy link

The build for this PR has failed with the following error(s):

pages/common/f3probe.md:10: TLDR005 Example descriptions should end in a colon

Please fix the error(s) and push again.

Aracki
Aracki approved these changes May 19, 2019
View reviewed changes
Copy link
Collaborator

@Aracki Aracki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aracki Aracki merged commit 8be8ce8 into master May 19, 2019
@mebeim mebeim deleted the page/f3probe branch May 28, 2019 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenvoke owenvoke owenvoke approved these changes

@Aracki Aracki Aracki approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sbrl @tldr-bot @owenvoke @Aracki