Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkfs: add page #3284

Merged
merged 3 commits into from Oct 2, 2019
Merged

mkfs: add page #3284

merged 3 commits into from Oct 2, 2019

Conversation

johncurcio
Copy link
Contributor

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.

Relates to #2214

@tldr-bot
Copy link

tldr-bot commented Oct 1, 2019

The build for this PR has failed with the following error(s):

pages/linux/mkfs.md:4: TLDR003 Descriptions should start with a capital letter

Please fix the error(s) and push again.

Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Got a few minor comments.

pages/linux/mkfs.md Outdated Show resolved Hide resolved
pages/linux/mkfs.md Outdated Show resolved Hide resolved
pages/linux/mkfs.md Outdated Show resolved Hide resolved
@agnivade agnivade added the new command Issues requesting creation of a new page. label Oct 1, 2019
Add examples of filesystem type ext4 and ntfs
Enhance deprecated description of mkfs
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @johncurcio!

A teensy thing would be that perhaps Create might sound batter than Build, but I think it's fine either way.

@sbrl sbrl merged commit dc7c28a into tldr-pages:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants