Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-commands: add Italian translations #3318

Merged
merged 6 commits into from Oct 6, 2019

Conversation

glenacota
Copy link
Collaborator

@glenacota glenacota commented Oct 3, 2019

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Closes #3317.

@glenacota
Copy link
Collaborator Author

Issue: #3317

@owenvoke owenvoke added the translation Translate pages from one language to another. label Oct 3, 2019
Copy link
Collaborator

@schneiderl schneiderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know the language but merge when ready.

Copy link
Collaborator

@schneiderl schneiderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know the language but merge when ready.

@agnivade
Copy link
Member

agnivade commented Oct 4, 2019

@glenacota - It would be good if you can split each page into it's own commit. That way it is easy to revert anything if needed.

@agnivade agnivade requested a review from mebeim October 4, 2019 03:41
@glenacota
Copy link
Collaborator Author

@glenacota - It would be good if you can split each page into it's own commit. That way it is easy to revert anything if needed.

Fair point! I'll do it next time

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @glenacota!

I don't speak Italian, but this looks ok to me.

@mebeim
Copy link
Member

mebeim commented Oct 4, 2019

Thank you for the PR :) will check as soon as I can.

Copy link
Member

@mebeim mebeim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, took some time but I checked everything. Thank you very much for these translations! Great to see some more italian pages 🙂.

Since you submitted a PR with 10 files, it would be preferable to keep the single commits when merging, so take the time you need to address my comments below (reply to them if you have any doubt/question/suggestion).

When ready, apply all of the needed changes and do a force-push to this branch so that I can check all at once. These changes cannot unfortunately be applied via GitHub web interface since that would create new commits, you will have to do it manually with an interactive rebase to keep the commits separate and then do a force push. Let me know if there's any trouble. I could also apply the changes for you if you don't want / don't have the time, just let me know.

Whelp, I can't count, this PR only has one commit so it's ok to edit in any way you want.

pages.it/common/git-am.md Outdated Show resolved Hide resolved
pages.it/common/git-bisect.md Show resolved Hide resolved
pages.it/common/git-bisect.md Outdated Show resolved Hide resolved
pages.it/common/git-bisect.md Show resolved Hide resolved
pages.it/common/git-bisect.md Outdated Show resolved Hide resolved
pages.it/common/git-clean.md Outdated Show resolved Hide resolved
pages.it/common/git-clean.md Outdated Show resolved Hide resolved
pages.it/common/git-clean.md Outdated Show resolved Hide resolved
pages.it/common/git-clean.md Outdated Show resolved Hide resolved
pages.it/common/git-clean.md Outdated Show resolved Hide resolved
@glenacota
Copy link
Collaborator Author

Hi @mebeim, thanks a lot for your feedback! (and thanks all for the support)
I'm going to take your feedback into account (I'll reply to some of your comments, directly, soon), but I was thinking of a different strategy for fixing them than your proposal of using force-push/interactive-rebase.

What do you think about me closing this PR, and create a new one with the translation of all the git-commands, each one in its own commit? That it would be - hopefully - simpler to review, and compliant to the best practice that you recommended me to apply.

@mebeim
Copy link
Member

mebeim commented Oct 5, 2019

@glenacota oh, pardon me. I thought this PR had 10 different commits. That's why I was talking about force push to preserve them. That would have been a problem. I see this PR only has one commit, so it's fine to fix every change adding commits or even using the web ui! They will all get squashed into one anyway when we merge.

What do you think about me closing this PR, and create a new one with the translation of all the git-commands, each one in its own commit?

That's exactly what I would try to avoid actually, because PRs with multiple pages on different commits are hard to review without breaking the commits. You can either leave this open OR create 10 single-page PRs. I would suggest the first one since I already reviewed it now, but for the future, one page per PR is almost always better.

pages.it/common/git-add.md Outdated Show resolved Hide resolved
@glenacota
Copy link
Collaborator Author

Ahoy @mebeim, shall we merge? :) this way, I'll proceed with the other translations

Copy link
Member

@mebeim mebeim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one little thing left. Looks good after this.

pages.it/common/git-checkout.md Outdated Show resolved Hide resolved
@mebeim mebeim merged commit 4ee9199 into tldr-pages:master Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git-commands in Italian
6 participants