New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-commands: add Italian translations #3318
git-commands: add Italian translations #3318
Conversation
Issue: #3317 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know the language but merge when ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know the language but merge when ready.
@glenacota - It would be good if you can split each page into it's own commit. That way it is easy to revert anything if needed. |
Fair point! I'll do it next time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @glenacota!
I don't speak Italian, but this looks ok to me.
Thank you for the PR :) will check as soon as I can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, took some time but I checked everything. Thank you very much for these translations! Great to see some more italian pages 🙂.
Since you submitted a PR with 10 files, it would be preferable to keep the single commits when merging, so take the time you need to address my comments below (reply to them if you have any doubt/question/suggestion).
When ready, apply all of the needed changes and do a force-push to this branch so that I can check all at once. These changes cannot unfortunately be applied via GitHub web interface since that would create new commits, you will have to do it manually with an interactive rebase to keep the commits separate and then do a force push. Let me know if there's any trouble. I could also apply the changes for you if you don't want / don't have the time, just let me know.
Whelp, I can't count, this PR only has one commit so it's ok to edit in any way you want.
Hi @mebeim, thanks a lot for your feedback! (and thanks all for the support) What do you think about me closing this PR, and create a new one with the translation of all the git-commands, each one in its own commit? That it would be - hopefully - simpler to review, and compliant to the best practice that you recommended me to apply. |
@glenacota oh, pardon me. I thought this PR had 10 different commits. That's why I was talking about force push to preserve them. That would have been a problem. I see this PR only has one commit, so it's fine to fix every change adding commits or even using the web ui! They will all get squashed into one anyway when we merge.
That's exactly what I would try to avoid actually, because PRs with multiple pages on different commits are hard to review without breaking the commits. You can either leave this open OR create 10 single-page PRs. I would suggest the first one since I already reviewed it now, but for the future, one page per PR is almost always better. |
817e3a7
to
a3c9ac6
Compare
Ahoy @mebeim, shall we merge? :) this way, I'll proceed with the other translations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one little thing left. Looks good after this.
common/
,linux/
, etc.)Closes #3317.