Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox: add extra flag options #3371

Merged
merged 6 commits into from Dec 27, 2019
Merged

firefox: add extra flag options #3371

merged 6 commits into from Dec 27, 2019

Conversation

scttrgd
Copy link
Contributor

@scttrgd scttrgd commented Oct 10, 2019

also added note that profile selection is not available on windows

  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

also added note that profile selection is not available on windows
@CLAassistant
Copy link

CLAassistant commented Oct 10, 2019

CLA assistant check
All committers have signed the CLA.

@tldr-bot
Copy link

The build for this PR has failed with the following error(s):

pages/common/firefox.md:39: TLDR103 Command example is missing its closing backtick

Please fix the error(s) and push again.

@schneiderl schneiderl added the page edit Changes to an existing page(s). label Oct 10, 2019
pages/common/firefox.md Outdated Show resolved Hide resolved
pages/common/firefox.md Outdated Show resolved Hide resolved
pages/common/firefox.md Outdated Show resolved Hide resolved
scttrgd and others added 2 commits October 14, 2019 14:55
grammatical change for default browser flag

Co-Authored-By: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
New instance flag removed but profile flag re-added
@scttrgd scttrgd requested a review from sbrl October 15, 2019 14:56
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh! We've now got 9 examples, which puts us over our limit of 8. Sorry to be a pain, but is there another less useful example that we could remove?

@scttrgd
Copy link
Contributor Author

scttrgd commented Oct 16, 2019

I personally rarely use the --search flag, but I obviously don't speak for everyone. Any objections to removing that flag?

@sbrl
Copy link
Member

sbrl commented Oct 16, 2019

I mean I'm not a huge user of the CLI for Firefox. I'd tend towards removing the most complex and least frequently used command myself. Commands like that are generally useful only in scripting, which isn't generally a 'beginner-friendly' use-case.


`firefox --new-instance --profile {{path/to/directory}} {{https://example.com/}}`

- Create a new profile in the default directory without starting Firefox:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems the least useful to me. Most of the time you use only one profile, especially as a beginner. How about removing this to resolve the issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm, yeah. Firefox should create a new profile automatically if you specify the profile directory.

@zdroid: Only 1 instance of Firefox per profile may be started at any given time. To this end, if you do headless CLI Firefox stuff you usually need to specify a different directory for it to use instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So to conclude, do you agree with me? I'll commit the change if you ultimately do.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do ultimately agree, but for different reasons, which I felt is an important distinction.

@stale
Copy link

stale bot commented Dec 26, 2019

Hi all! This thread has not had any recent activity. Are there any updates? Thanks!

@stale stale bot added the waiting Issues/PRs with Pending response by the author. label Dec 26, 2019
@stale stale bot removed the waiting Issues/PRs with Pending response by the author. label Dec 26, 2019
@zlatanvasovic
Copy link
Contributor

There has been no response for 2 months, so I committed the changes myself.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @scttrgd and @zdroid!

@sbrl sbrl merged commit 3f48086 into tldr-pages:master Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants