New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
firefox: add extra flag options #3371
Conversation
also added note that profile selection is not available on windows
The build for this PR has failed with the following error(s):
Please fix the error(s) and push again. |
grammatical change for default browser flag Co-Authored-By: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
New instance flag removed but profile flag re-added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh oh! We've now got 9 examples, which puts us over our limit of 8. Sorry to be a pain, but is there another less useful example that we could remove?
I personally rarely use the |
I mean I'm not a huge user of the CLI for Firefox. I'd tend towards removing the most complex and least frequently used command myself. Commands like that are generally useful only in scripting, which isn't generally a 'beginner-friendly' use-case. |
pages/common/firefox.md
Outdated
|
||
`firefox --new-instance --profile {{path/to/directory}} {{https://example.com/}}` | ||
|
||
- Create a new profile in the default directory without starting Firefox: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems the least useful to me. Most of the time you use only one profile, especially as a beginner. How about removing this to resolve the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm, yeah. Firefox should create a new profile automatically if you specify the profile directory.
@zdroid: Only 1 instance of Firefox per profile may be started at any given time. To this end, if you do headless CLI Firefox stuff you usually need to specify a different directory for it to use instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So to conclude, do you agree with me? I'll commit the change if you ultimately do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do ultimately agree, but for different reasons, which I felt is an important distinction.
Hi all! This thread has not had any recent activity. Are there any updates? Thanks! |
There has been no response for 2 months, so I committed the changes myself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also added note that profile selection is not available on windows
common/
,linux/
, etc.)