Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

findfs: add page #3850

Merged
merged 2 commits into from
Feb 13, 2020
Merged

findfs: add page #3850

merged 2 commits into from
Feb 13, 2020

Conversation

mt-empty
Copy link
Contributor

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

schneiderl
schneiderl requested changes Feb 12, 2020
View reviewed changes
pages/linux/findfs.md Outdated

- Search block devices by filesystem UUID:

`findfs UUID={{label}}`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`findfs UUID={{label}}`
`findfs UUID={{uuid}}`

pages/linux/findfs.md Outdated

- Search block devices by partition UUID (GPT or MAC partition table):

`findfs PARTLABEL={{label}}`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should change "label" here to some that make more sense with the description. partition_uuid perhaps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also I got this one mixed up with the one below

pages/linux/findfs.md Outdated

- Search block devices by partition label (GPT partition table only):

`findfs PARTUUID={{label}}`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

zlatanvasovic
zlatanvasovic approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@zlatanvasovic zlatanvasovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good after the other review's comments are resolved.

@Geipro Geipro added the new command Issues requesting creation of a new page. label Feb 12, 2020
@zlatanvasovic zlatanvasovic merged commit a0f1158 into tldr-pages:master Feb 13, 2020
@vitorhcl vitorhcl mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schneiderl schneiderl schneiderl approved these changes

@zlatanvasovic zlatanvasovic Awaiting requested review from zlatanvasovic

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mt-empty @zlatanvasovic @schneiderl @Geipro