Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dos2unix/unix2dos: add pages #4024

Merged
merged 6 commits into from May 12, 2020
Merged

dos2unix/unix2dos: add pages #4024

merged 6 commits into from May 12, 2020

Conversation

fejx
Copy link
Contributor

@fejx fejx commented May 6, 2020 •
edited by zlatanvasovic

Closes #3897.

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@tldr-bot
Copy link

tldr-bot commented May 6, 2020

The build for this PR failed with the following error(s):

pages/linux/dos2unix.md:10: TLDR005 Example descriptions should end in a colon
pages/linux/dos2unix.md:13: TLDR008 File should contain no trailing whitespace
pages/linux/unix2dos.md:10: TLDR005 Example descriptions should end in a colon
pages/linux/unix2dos.md:13: TLDR008 File should contain no trailing whitespace

Please fix the error(s) and push again.

@fejx fejx force-pushed the master branch 2 times, most recently from a9a48fa to 8bcaa07 Compare May 6, 2020 19:40
@fejx
Copy link
Contributor Author

fejx commented May 7, 2020

Just noticed that this PR closes #3897

@Rudloff
Copy link
Collaborator

Rudloff commented May 7, 2020

Maybe you could also add mac2unix and unix2mac that are part of the same tool?

@einverne einverne added the new command Issues requesting creation of a new page. label May 9, 2020
zlatanvasovic
zlatanvasovic suggested changes May 10, 2020
View reviewed changes
Copy link
Contributor

@zlatanvasovic zlatanvasovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta be consistent.

pages/linux/dos2unix.md Outdated Show resolved Hide resolved
pages/linux/dos2unix.md Outdated Show resolved Hide resolved
pages/linux/mac2unix.md Outdated Show resolved Hide resolved
pages/linux/mac2unix.md Outdated Show resolved Hide resolved
pages/linux/unix2dos.md Outdated Show resolved Hide resolved
pages/linux/unix2dos.md Outdated Show resolved Hide resolved
pages/linux/unix2mac.md Outdated Show resolved Hide resolved
pages/linux/unix2mac.md Outdated Show resolved Hide resolved
sbrl
sbrl reviewed May 10, 2020
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new pages @fejx! I've just left some really minor comments below, and then this is good to go :-)

Thanks again :D

pages/linux/unix2mac.md Outdated Show resolved Hide resolved
pages/linux/unix2dos.md Outdated Show resolved Hide resolved
pages/linux/mac2unix.md Outdated Show resolved Hide resolved
pages/linux/dos2unix.md Outdated Show resolved Hide resolved
@fejx
Copy link
Contributor Author

fejx commented May 10, 2020 •
edited

Thanks for the new pages @fejx! I've just left some really minor comments below, and then this is good to go :-)

Thanks again :D

You are welcome!

Your correction makes a lot of sense, since my phrasing would mean that just some of the line endings get replaced, when it's actually all of them. I am amazed at how thorough you are.

fejx and others added 6 commits May 10, 2020 22:45
@fejx
unix2dos: add page
b572078
@fejx
dos2unix: add page
dc13690
@fejx
mac2unix: add page
210bef1
@fejx
unix2mac: add page
7b1f2a9
@fejx @zlatanvasovic
dos2unix, unix2dos, mac2unix, unix2mac: use consistent naming
f54990b 
Apply suggestions from code review

Co-authored-by: Zlatan Vasović <zlatanvasovic@gmail.com>
@fejx @sbrl
dos2unix, unix2dos, mac2unix, unix2mac: rephrase wording in first exa…
8313ef0 
…mple


Adding 'the' is more accurate because it's *all* of the line endings that get replaced, not just *some* of them.

Apply suggestions from code review

Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@sbrl
Copy link
Member

sbrl commented May 12, 2020

No problem!

And haha yeah, I do suspect I'm one of the more thorough tldr pages reviewers lol

It's kind of a thing I do :P

sbrl
sbrl approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, thanks @fejx 😺

@sbrl sbrl merged commit 2522bce into tldr-pages:master May 12, 2020
@fazlearefin fazlearefin mentioned this pull request Apr 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zlatanvasovic zlatanvasovic zlatanvasovic approved these changes

@sbrl sbrl sbrl approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

page request: dos2unix / unix2dos
6 participants
@fejx @tldr-bot @Rudloff @sbrl @zlatanvasovic @einverne