Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnf: add and reorder examples #4063

Merged
merged 10 commits into from May 28, 2020
Merged

dnf: add and reorder examples #4063

merged 10 commits into from May 28, 2020

Conversation

jn64
Copy link
Contributor

@jn64 jn64 commented May 24, 2020

  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

jn64 added 7 commits May 24, 2020 15:09
sudo not needed for search and other queries
Although `provides` can search the 'provides' metadata of packages, it's most commonly going to be used to search for specific files DNF manual also refers to it as 'file', see <https://dnf.readthedocs.io/en/latest/command_ref.html#provides-command>
Put commands that new users are more likely to use at the top, and in a logical flow (search > info > install).
@CLAassistant
Copy link

CLAassistant commented May 24, 2020

CLA assistant check
All committers have signed the CLA.

pages/linux/dnf.md Outdated Show resolved Hide resolved
Co-authored-by: Zlatan Vasović <zlatanvasovic@gmail.com>
@jn64
Copy link
Contributor Author

jn64 commented May 24, 2020

I signed the CLA an hour ago.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/linux/dnf.md:4: TLDR004 Command descriptions should end in a period

Please fix the error(s) and push again.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/linux/dnf.md:4: TLDR004 Command descriptions should end in a period

Please fix the error(s) and push again.

@andrik andrik added the page edit Changes to an existing page(s). label May 27, 2020
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks @jn64! I've left a really minor comment below for you to review. It's pretty much as-is though, so I'm approving :-)

Your issue with the CLAAssistant might be because you committed using an email address that isn't associated with your GitHub account. CLAAssisstant needs you to commit with email addresses that are associated with your GitHub account. You can also add the additional email address to your GitHub account, and this will fix the issue too :-)

Thanks again for the great contribution! This is certainly a huge improvement to this page :D

pages/linux/dnf.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@andrik andrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @jn64 and welcome to the project

@jn64
Copy link
Contributor Author

jn64 commented May 28, 2020

@sbrl These commits were made on GitHub web, as you can see on the Verified tags on each commit, so the email is most definitely associated. However I'm using GitHub's private email option. I don't know how CLAassistant handles that.

edit: it was an issue with cookies on CLAa which I've resolved.

Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@zlatanvasovic zlatanvasovic merged commit c7ae6b3 into tldr-pages:master May 28, 2020
@jn64 jn64 deleted the patch-1 branch May 29, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants