Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login: add page #4509

Merged
merged 6 commits into from Oct 6, 2020
Merged

login: add page #4509

merged 6 commits into from Oct 6, 2020

Conversation

en1gma713
Copy link
Contributor

@en1gma713 en1gma713 commented Oct 5, 2020

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2020

CLA assistant check
All committers have signed the CLA.

@tldr-bot
Copy link

tldr-bot commented Oct 5, 2020

The build for this PR failed with the following error(s):

pages/linux/login.md:3: TLDR004 Command descriptions should end in a period
pages/linux/login.md:4: TLDR011 Page never contains more than a single empty line

Please fix the error(s) and push again.

@tldr-bot
Copy link

tldr-bot commented Oct 5, 2020

The build for this PR failed with the following error(s):

pages/linux/login.md:1 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "# Login"]
pages/linux/login.md:5: TLDR007 Example descriptions should be surrounded by empty lines
pages/linux/login.md:8: TLDR007 Example descriptions should be surrounded by empty lines
pages/linux/login.md:11: TLDR007 Example descriptions should be surrounded by empty lines
pages/linux/login.md:14: TLDR007 Example descriptions should be surrounded by empty lines
pages/linux/login.md:1: TLDR006 Command name and description should be separated by an empty line

Please fix the error(s) and push again.

@en1gma713
Copy link
Contributor Author

#2214

@owenvoke owenvoke added the new command Issues requesting creation of a new page. label Oct 6, 2020
Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @en1gma713, just a few small grammatical changes and token syntax additions, but otherwise this looks good. Thanks!

pages/linux/login.md Outdated Show resolved Hide resolved
pages/linux/login.md Outdated Show resolved Hide resolved
pages/linux/login.md Outdated Show resolved Hide resolved
pages/linux/login.md Outdated Show resolved Hide resolved
pages/linux/login.md Outdated Show resolved Hide resolved
@en1gma713
Copy link
Contributor Author

done

Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @en1gma713. 🥳

@navarroaxel navarroaxel merged commit f4c4ce2 into tldr-pages:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants