Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lslogins: add page #4563

Merged
merged 5 commits into from Oct 12, 2020
Merged

lslogins: add page #4563

merged 5 commits into from Oct 12, 2020

Conversation

en1gma713
Copy link
Contributor

@en1gma713 en1gma713 commented Oct 7, 2020

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@tldr-bot
Copy link

tldr-bot commented Oct 7, 2020

The build for this PR failed with the following error(s):

Error: Parse error on line 5:
... the Linux system.> More information: 
---------------------^
Expecting 'TEXT', 'DASH', 'BACKTICK', got 'GREATER_THAN'

Please fix the error(s) and push again.

@navarroaxel navarroaxel added the new command Issues requesting creation of a new page. label Oct 7, 2020
Copy link
Member

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @en1gma713, nice work, I left some comments.

Could you add --last (last login), --system-accs and --supp-groups examples?

pages/linux/lslogins.md Outdated Show resolved Hide resolved
pages/linux/lslogins.md Outdated Show resolved Hide resolved
pages/linux/lslogins.md Outdated Show resolved Hide resolved
pages/linux/lslogins.md Outdated Show resolved Hide resolved
Copy link
Member

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @en1gma713, just 1 comment.

pages/linux/lslogins.md Outdated Show resolved Hide resolved
Copy link
Member

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @en1gma713 👍

pages/linux/lslogins.md Outdated Show resolved Hide resolved
@navarroaxel navarroaxel requested a review from sbrl October 10, 2020 20:59
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @en1gma713 ❤️

@sbrl sbrl merged commit 4d06885 into tldr-pages:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants