Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addpart: add page #4649

Merged
merged 5 commits into from Oct 12, 2020
Merged

addpart: add page #4649

merged 5 commits into from Oct 12, 2020

Conversation

jenesh
Copy link
Contributor

@jenesh jenesh commented Oct 11, 2020

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

This PR is in support of #2214.

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2020

CLA assistant check
All committers have signed the CLA.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/linux/addpart.md:3: TLDR004 Command descriptions should end in a period
pages/linux/addpart.md:5: TLDR104 Example descriptions should prefer infinitive tense (e.g. write) over present (e.g. writes) or gerund (e.g. writing)

Please fix the error(s) and push again.

@navarroaxel navarroaxel added the new command Issues requesting creation of a new page. label Oct 11, 2020
Copy link
Member

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jenesh, I left some comments.

pages/linux/addpart.md Outdated Show resolved Hide resolved
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Copy link
Member

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jenesh!

@sbrl sbrl merged commit 7bf5162 into tldr-pages:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants