Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cfdisk: add page #4881

Merged
merged 4 commits into from
Oct 28, 2020
Merged

cfdisk: add page #4881

merged 4 commits into from
Oct 28, 2020

Conversation

mtausig
Copy link
Contributor

@mtausig mtausig commented Oct 27, 2020

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Add new page for the command cfdisk.

Part of #2214

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/linux/cfdisk.md:4: TLDR004 Command descriptions should end in a period

Please fix the error(s) and push again.

@navarroaxel navarroaxel added the new command Issues requesting creation of a new page. label Oct 28, 2020
@navarroaxel navarroaxel changed the title Add new page cfdisk cfdisk: add page Oct 28, 2020
navarroaxel
navarroaxel requested changes Oct 28, 2020
View reviewed changes
Copy link
Member

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mtausig, welcome and thanks for your submission. I left some comments.

Please don't push force to the PRs, it's harder to us to track the changes and suggestions.

pages/linux/cfdisk.md Outdated Show resolved Hide resolved
pages/linux/cfdisk.md Outdated Show resolved Hide resolved
pages/linux/cfdisk.md Outdated Show resolved Hide resolved
pages/linux/cfdisk.md Outdated Show resolved Hide resolved
@navarroaxel navarroaxel added the translation Translate pages from one language to another. label Oct 28, 2020
mtausig and others added 2 commits October 28, 2020 14:00
@mtausig
Copy link
Contributor Author

mtausig commented Oct 28, 2020

Please don't push force to the PRs, it's harder to us to track the changes and suggestions.

Sorry. I just added the style fixes to appease the linter. I thought it would be easier if I did that before the review, but I can squash at the end, too if you prefer that.

@navarroaxel
Copy link
Member

@mtausig don't worry, we squash and merge the PR

@sbrl sbrl added the hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. label Oct 28, 2020
sbrl
sbrl approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mtausig!

@sbrl sbrl merged commit 15fa534 into tldr-pages:master Oct 28, 2020
@mtausig mtausig deleted the cfdisk branch October 28, 2020 19:28
@vitorhcl vitorhcl mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@sbrl sbrl sbrl approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted PRs that were opened for Hacktoberfest, but may not actually get merged until November. new command Issues requesting creation of a new page. translation Translate pages from one language to another.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mtausig @tldr-bot @navarroaxel @sbrl