Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh: add reverse proxy example #5164

Closed
wants to merge 1 commit into from
Closed

ssh: add reverse proxy example #5164

wants to merge 1 commit into from

Conversation

yangvw
Copy link

@yangvw yangvw commented Jan 20, 2021

  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@navarroaxel navarroaxel changed the title Add SSH reverse proxy ssh: add reverse proxy example Jan 20, 2021
@navarroaxel navarroaxel added the page edit Changes to an existing page(s). label Jan 20, 2021
@navarroaxel
Copy link
Member

Hi @yangvw, could you please sign the license to pass the license/cla check?

Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @yangvw and thank you for page update! I've left some comments below for you to review.

@@ -31,6 +27,10 @@

`ssh -J {{username}}@{{jump_host}} {{username}}@{{remote_host}}`

- SSH reverse proxy: Expose a localhost port on the remote server (Set `GatewayPorts yes` in sshd_config to allow internet access):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things here:

  1. Does "localhost port on the remote server" mean a port that is open on the server, localhost referring to the server itself?
  2. "Set GatewayPorts yes in sshd_config" — is sshd_config on the server or client?

Also, will you please put sshd_config in backticks per WIP PR #5128?

@@ -31,6 +27,10 @@

`ssh -J {{username}}@{{jump_host}} {{username}}@{{remote_host}}`

- SSH reverse proxy: Expose a localhost port on the remote server (Set `GatewayPorts yes` in sshd_config to allow internet access):

`ssh -NTR {{remote_port}}:localhost:{{local_port}} {{remote_host}}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this duplicates the ssh -L {{9999}}:{{example.org}}:{{80}} example and also a bit inconsistent with it.

Comment on lines +14 to +16
- Connect to a remote server using a specific port and run a command:

`ssh {{username}}@{{remote_host}} -p {{2222}}`

- Run a command on a remote server:

`ssh {{remote_host}} {{command -with -flags}}`
`ssh {{username}}@{{remote_host}} -p {{2222}} {{command -with -flags}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of combining these examples here. It makes the page more dense and difficult to follow for the beginner.

@bl-ue
Copy link
Contributor

bl-ue commented Feb 6, 2021

Closing as the author seems unavailable and the PR appears to be redundant.

@bl-ue bl-ue closed this Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants