Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user*, group*, add*, group*: add more info links #5738

Merged

Conversation

patricedenis
Copy link
Collaborator

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@patricedenis
Copy link
Collaborator Author

patricedenis commented Apr 12, 2021

#5510

@marchersimon marchersimon added page edit Changes to an existing page(s). mass changes Changes that affect multiple pages. labels Apr 12, 2021
Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @patricedenis. I left a few suggestions below.

pages.es/linux/groupdel.md Outdated Show resolved Hide resolved
pages.it/linux/adduser.md Outdated Show resolved Hide resolved
@patricedenis
Copy link
Collaborator Author

patricedenis commented Apr 14, 2021

why when you click on resolved, the historic of some conversations is erased?

pages.it/linux/adduser.md Outdated Show resolved Hide resolved
pages.it/linux/deluser.md Outdated Show resolved Hide resolved
pages.ko/linux/deluser.md Outdated Show resolved Hide resolved
pages.pt_BR/linux/adduser.md Outdated Show resolved Hide resolved
pages.zh/linux/adduser.md Outdated Show resolved Hide resolved
pages/linux/adduser.md Outdated Show resolved Hide resolved
pages/linux/deluser.md Outdated Show resolved Hide resolved
@bl-ue
Copy link
Contributor

bl-ue commented Apr 14, 2021

why when you click on resolved, the historic of some conversations is erased?

@patricedenis when you apply suggestions, sometimes they delete lines, so conversations made on those lines are hidden, but only in the "Files Changed" tab. In the "Conversation" tab, you can still see them all; they're just minimized.

patricedenis and others added 7 commits April 15, 2021 17:27
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@Waples Waples merged commit ce747d2 into tldr-pages:master Apr 17, 2021
@patricedenis patricedenis deleted the user-management-tools-add-more-info-links branch April 18, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mass changes Changes that affect multiple pages. page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants