Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-ecr: add page #6134

Merged
merged 17 commits into from Jun 23, 2021
Merged

aws-ecr: add page #6134

merged 17 commits into from Jun 23, 2021

Conversation

258204
Copy link
Collaborator

@258204 258204 commented Jun 17, 2021

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

For #5653

@258204
Copy link
Collaborator Author

258204 commented Jun 17, 2021

I included some commands where the base command involves a different application, but illustrates how ecr interacts with them. Most of these are adapted from here: https://docs.aws.amazon.com/AmazonECR/latest/userguide/getting-started-cli.html

@bl-ue bl-ue added the new command Issues requesting creation of a new page. label Jun 17, 2021
@bl-ue bl-ue mentioned this pull request Jun 17, 2021
pages/common/aws-ecr.md Outdated Show resolved Hide resolved
pages/common/aws-ecr.md Outdated Show resolved Hide resolved
pages/common/aws-ecr.md Outdated Show resolved Hide resolved
pages/common/aws-ecr.md Outdated Show resolved Hide resolved
pages/common/aws-ecr.md Outdated Show resolved Hide resolved
258204 and others added 5 commits June 18, 2021 02:30
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor.

pages/common/aws-ecr.md Outdated Show resolved Hide resolved
pages/common/aws-ecr.md Outdated Show resolved Hide resolved
pages/common/aws-ecr.md Outdated Show resolved Hide resolved
258204 and others added 3 commits June 18, 2021 04:47
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@258204 258204 requested a review from bl-ue June 17, 2021 19:19
pages/common/aws-ecr.md Outdated Show resolved Hide resolved
pages/common/aws-ecr.md Outdated Show resolved Hide resolved
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
258204 and others added 4 commits June 22, 2021 01:12
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
@bl-ue bl-ue requested a review from navarroaxel June 21, 2021 21:17
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
@marchersimon marchersimon merged commit 1d37695 into tldr-pages:main Jun 23, 2021
@258204 258204 deleted the aws-ecr branch November 28, 2021 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants