New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fdisk: refresh #6196
fdisk: refresh #6196
Conversation
- Once partitioning a disk, create a partition: | ||
|
||
`n` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be looked at, the syntax for adding memory disk allocation is +{{size}}{{K|M|G|T|P}}
To a beginner and me, that is odd. I would put 500M or 500MB or 500 MB, then be confused that it didn't work and have to look it up on my phone, which is annoying enough (when installing arch, unable to use a web browser)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only possible solution I can see is maybe putting that in the description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fdisk
is an interactive command, so you don't specify the syntax for the size of the partition here - I'm confused what you're referring to here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the command prompt, it is done during the command,
EG
$ sudo fdisk /dev/sda
new
Enter size of partition 1 +500M
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to put a +, which IMO is an odd syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you didn't add the g
command?
Probably because I have never used it, I am a BIOS boot person. UEFI booting just annoys me + I use DOS |
You could argue that both the MSDOS table and GPT are important, however in comparison to the others, they seem a little less useful since most people formatting their disks will already have a partition table, and just need to partition it correctly, however from a view point of just using the tool instead of GParted, then I could definitely see the use. However which is more important can be decided, I'd say p is the least important (still really useful), however all the others are command that everyone using the tool needs to know like discarding if mistakes are made or writing when ready |
Another thing that needs to be brought up here, do we make the commands long, i am pretty sure d can be turned into delete. Making them long might make it easier for a user, g - gpt gpt makes more sense |
In this case @CleanMachine1 although it would be beneficial to have long options, then man page and help does not mention it, so it's not officially supported. |
Open an fdisk (don't write to any disks) and type variations of commands, |
@@ -10,3 +10,27 @@ | |||
- Start the partition manipulator: | |||
|
|||
`fdisk {{/dev/sdX}}` | |||
|
|||
- Once partitioning a disk, create a partition: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
- Once partitioning a disk, create a partition: | |
- Create a partition within `fdisk`: |
Maybe also inside of
or in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like that. To me that just means,
when you use this command, it creates a partition.
or in tldr terms
- Create a partition:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It being interactive shows that you need a previous command to reach that stage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what the within fdisk
is for. It tells you that you have to be inside of fdisk (running it) to be able to execute the command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It guess, but I don't think it does as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Once partitioning a disk, create a partition: | |
- Once manipulating a disk, create a partition: |
- Once partitioning a disk, create a partition: | |
- Once editing a disk, create a partition: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the original one in this case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're keeping that sentence structure, I'd prefer Once partitioning a disk, ...
like it is right now.
Yes, while I don't deny it works it's not officially documented, so it's not guaranteed that it's not going to change in the future. Also, practically all modern operating systems use GPT partition tables - even without UEFI booting (which I might add still allows you to disable secure boot, which for me is what really annoys me)? |
Yep, with UEFI and GPT you can still disable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @CleanMachine1!
fdisk is a crucial disk editing command, which is key for setting up Arch Linux for example.
However it is not documented very well and is a useful command itself when things like GParted aren't available because someone doesn't have a desktop
My edits will need a little help