Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fdisk: refresh #6196

Merged
merged 4 commits into from Jul 22, 2021
Merged

fdisk: refresh #6196

merged 4 commits into from Jul 22, 2021

Conversation

CleanMachine1
Copy link
Member

fdisk is a crucial disk editing command, which is key for setting up Arch Linux for example.

However it is not documented very well and is a useful command itself when things like GParted aren't available because someone doesn't have a desktop

My edits will need a little help

@CleanMachine1 CleanMachine1 added the page edit Changes to an existing page(s). label Jul 5, 2021
Comment on lines +14 to +17
- Once partitioning a disk, create a partition:

`n`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be looked at, the syntax for adding memory disk allocation is +{{size}}{{K|M|G|T|P}}

To a beginner and me, that is odd. I would put 500M or 500MB or 500 MB, then be confused that it didn't work and have to look it up on my phone, which is annoying enough (when installing arch, unable to use a web browser)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only possible solution I can see is maybe putting that in the description

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fdisk is an interactive command, so you don't specify the syntax for the size of the partition here - I'm confused what you're referring to here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the command prompt, it is done during the command,

EG

$ sudo fdisk /dev/sda

new

Enter size of partition 1 +500M

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to put a +, which IMO is an odd syntax

Copy link
Member

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you didn't add the g command?

pages/linux/fdisk.md Show resolved Hide resolved
@CleanMachine1
Copy link
Member Author

CleanMachine1 commented Jul 5, 2021

Why you didn't add the g command?

Probably because I have never used it, I am a BIOS boot person. UEFI booting just annoys me + I use DOS

@CleanMachine1
Copy link
Member Author

You could argue that both the MSDOS table and GPT are important, however in comparison to the others, they seem a little less useful since most people formatting their disks will already have a partition table, and just need to partition it correctly, however from a view point of just using the tool instead of GParted, then I could definitely see the use.

However which is more important can be decided, I'd say p is the least important (still really useful), however all the others are command that everyone using the tool needs to know like discarding if mistakes are made or writing when ready

@CleanMachine1
Copy link
Member Author

Another thing that needs to be brought up here, do we make the commands long, i am pretty sure d can be turned into delete.

Making them long might make it easier for a user,

g - gpt

gpt makes more sense

@sbrl
Copy link
Member

sbrl commented Jul 5, 2021

In this case @CleanMachine1 although it would be beneficial to have long options, then man page and help does not mention it, so it's not officially supported.

@CleanMachine1
Copy link
Member Author

Open an fdisk (don't write to any disks) and type variations of commands, ne counts as n, so it seems to cover for the user regardless of typos

pages/linux/fdisk.md Outdated Show resolved Hide resolved
@@ -10,3 +10,27 @@
- Start the partition manipulator:

`fdisk {{/dev/sdX}}`

- Once partitioning a disk, create a partition:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about

Suggested change
- Once partitioning a disk, create a partition:
- Create a partition within `fdisk`:

Maybe also inside of or in

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like that. To me that just means,

when you use this command, it creates a partition.

or in tldr terms

  • Create a partition:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It being interactive shows that you need a previous command to reach that stage

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what the within fdisk is for. It tells you that you have to be inside of fdisk (running it) to be able to execute the command.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It guess, but I don't think it does as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Once partitioning a disk, create a partition:
- Once manipulating a disk, create a partition:
Suggested change
- Once partitioning a disk, create a partition:
- Once editing a disk, create a partition:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the original one in this case

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your suggestion?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're keeping that sentence structure, I'd prefer Once partitioning a disk, ... like it is right now.

@sbrl
Copy link
Member

sbrl commented Jul 6, 2021

Open an fdisk (don't write to any disks) and type variations of commands, ne counts as n, so it seems to cover for the user regardless of typos

Yes, while I don't deny it works it's not officially documented, so it's not guaranteed that it's not going to change in the future.

Also, practically all modern operating systems use GPT partition tables - even without UEFI booting (which I might add still allows you to disable secure boot, which for me is what really annoys me)?

@navarroaxel
Copy link
Member

navarroaxel commented Jul 6, 2021

Also, practically all modern operating systems use GPT partition tables - even without UEFI booting (which I might add still allows you to disable secure boot, which for me is what really annoys me)?

Yep, with UEFI and GPT you can still disable secure boot.

pages/linux/fdisk.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @CleanMachine1!

@sbrl sbrl merged commit c7cf075 into main Jul 22, 2021
@sbrl sbrl deleted the fdisk branch July 22, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants